Fix search API response type and license field polymorphism

The Gitee search endpoint returns a plain JSON array, not a wrapper
object. The license field alternates between a bare string and an
object depending on the endpoint; UnmarshalJSON handles both forms.
Also strip trailing .git from html_url when building the web URL.

Author: tamnd

gitee/gitee.go

@@ -151,6 +151,7 @@ func (c *Client) getJSON(ctx context.Context, rawURL string, v any) error {
 // ─── API methods ─────────────────────────────────────────────────────────────
 
 // SearchRepos searches Gitee repositories. sort: "stars", "forks", "updated".
+// The Gitee search endpoint returns a plain JSON array (not a wrapper object).
 func (c *Client) SearchRepos(ctx context.Context, query, lang, sort string, limit int) ([]Repo, error) {
 	if limit <= 0 {
 		limit = 20
@@ -183,17 +184,17 @@ func (c *Client) SearchRepos(ctx context.Context, query, lang, sort string, limi
 		params.Set("per_page", strconv.Itoa(pageSize))
 
 		rawURL := c.cfg.BaseURL + "/search/repositories?" + params.Encode()
-		var resp searchResp
-		if err := c.getJSON(ctx, rawURL, &resp); err != nil {
+		var repos []wireRepo
+		if err := c.getJSON(ctx, rawURL, &repos); err != nil {
 			return out, err
 		}
-		for _, wr := range resp.Items {
+		for _, wr := range repos {
 			out = append(out, wireRepoToRepo(wr, len(out)+1))
 			if len(out) >= limit {
 				return out, nil
 			}
 		}
-		if len(resp.Items) == 0 {
+		if len(repos) == 0 {
 			break
 		}
 		page++

gitee/gitee_test.go

@@ -84,22 +84,19 @@ func TestGetNullReturnsNotFound(t *testing.T) {
 }
 
 func TestSearchRepos(t *testing.T) {
-	resp := searchResp{
-		TotalCount: 2,
-		Items: []wireRepo{
-			{FullName: "foo/bar", StargazersCount: 100, HTMLURL: "https://gitee.com/foo/bar"},
-			{FullName: "baz/qux", StargazersCount: 50, HTMLURL: "https://gitee.com/baz/qux"},
-		},
+	items := []wireRepo{
+		{FullName: "foo/bar", StargazersCount: 100, HTMLURL: "https://gitee.com/foo/bar.git"},
+		{FullName: "baz/qux", StargazersCount: 50, HTMLURL: "https://gitee.com/baz/qux.git"},
 	}
 	calls := 0
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		calls++
 		w.Header().Set("Content-Type", "application/json")
 		if calls > 1 {
-			_ = json.NewEncoder(w).Encode(searchResp{})
+			_ = json.NewEncoder(w).Encode([]wireRepo{})
 			return
 		}
-		_ = json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(items)
 	}))
 	defer srv.Close()
 
@@ -126,7 +123,7 @@ func TestGetRepo(t *testing.T) {
 	wr := wireRepo{
 		FullName:        "gitee/gitee",
 		StargazersCount: 999,
-		HTMLURL:         "https://gitee.com/gitee/gitee",
+		HTMLURL:         "https://gitee.com/gitee/gitee.git",
 		Language:        "Ruby",
 	}
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -144,7 +141,7 @@ func TestGetRepo(t *testing.T) {
 		t.Errorf("full_name = %q", repo.FullName)
 	}
 	if repo.URL != "https://gitee.com/gitee/gitee" {
-		t.Errorf("url = %q", repo.URL)
+		t.Errorf("url = %q, want https://gitee.com/gitee/gitee", repo.URL)
 	}
 	if repo.Stars != 999 {
 		t.Errorf("stars = %d", repo.Stars)

gitee/types.go

@@ -1,6 +1,10 @@
 package gitee
 
-import "fmt"
+import (
+	"encoding/json"
+	"fmt"
+	"strings"
+)
 
 // ─── Exported record types ────────────────────────────────────────────────────
 
@@ -62,8 +66,29 @@ type wireRepo struct {
 	Owner           wireOwner    `json:"owner"`
 }
 
+// wireLicense can appear as either an object {"spdx_id":"MIT"} or a bare
+// string "MIT" depending on which Gitee endpoint returns the repo.
 type wireLicense struct {
-	SPDXID string `json:"spdx_id"`
+	SPDXID string
+}
+
+func (l *wireLicense) UnmarshalJSON(b []byte) error {
+	if len(b) == 0 || string(b) == "null" {
+		return nil
+	}
+	// bare string form
+	if b[0] == '"' {
+		return json.Unmarshal(b, &l.SPDXID)
+	}
+	// object form
+	var obj struct {
+		SPDXID string `json:"spdx_id"`
+	}
+	if err := json.Unmarshal(b, &obj); err != nil {
+		return err
+	}
+	l.SPDXID = obj.SPDXID
+	return nil
 }
 
 type wireOwner struct {
@@ -95,14 +120,14 @@ type wireRelease struct {
 	Author     wireOwner `json:"author"`
 }
 
-type searchResp struct {
-	TotalCount int        `json:"total_count"`
-	Items      []wireRepo `json:"items"`
-}
-
 // ─── Conversion helpers ───────────────────────────────────────────────────────
 
 func wireRepoToRepo(wr wireRepo, rank int) Repo {
+	// The API html_url includes a trailing .git; strip it for the web URL.
+	webURL := strings.TrimSuffix(wr.HTMLURL, ".git")
+	if webURL == "" && wr.FullName != "" {
+		webURL = "https://gitee.com/" + wr.FullName
+	}
 	return Repo{
 		Rank:        rank,
 		FullName:    wr.FullName,
@@ -111,7 +136,7 @@ func wireRepoToRepo(wr wireRepo, rank int) Repo {
 		Stars:       wr.StargazersCount,
 		Forks:       wr.ForksCount,
 		UpdatedAt:   wr.UpdatedAt,
-		URL:         wr.HTMLURL,
+		URL:         webURL,
 	}
 }