Skip to content

Commit dcb8c4b

Browse files
committed
Update gradle and fix tests
1 parent 521369b commit dcb8c4b

7 files changed

Lines changed: 36 additions & 9 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ android {
3838
testOptions {
3939
unitTests.returnDefaultValues = true
4040
unitTests.includeAndroidResources = true
41+
animationsDisabled = true
4142
}
4243
}
4344

app/src/androidTest/java/jp/deadend/noname/skk/SKKSettingsActivityUITest.kt

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import androidx.test.espresso.Espresso.onView
1212
import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
1313
import androidx.test.espresso.Espresso.pressBack
1414
import androidx.test.espresso.NoMatchingViewException
15+
import androidx.test.espresso.action.EspressoKey
1516
import androidx.test.espresso.action.ViewActions.click
1617
import androidx.test.espresso.action.ViewActions.pressKey
1718
import androidx.test.espresso.action.ViewActions.swipeUp
@@ -242,7 +243,14 @@ class SKKSettingsActivityUITest {
242243
.perform(click())
243244
repeat(3) {
244245
Thread.sleep(1000)
245-
onView(withText("全角英数キー")).perform(pressKey(KeyEvent.KEYCODE_Z, KeyEvent.META_SHIFT_LEFT_ON))
246+
onView(withText("全角英数キー")).perform(
247+
pressKey(
248+
EspressoKey.Builder()
249+
.withKeyCode(KeyEvent.KEYCODE_Z)
250+
.withShiftPressed(true)
251+
.build()
252+
)
253+
)
246254
}
247255
onView(withText("全角英数キー")).check(matches(hasSibling(withText("SHIFT+Z"))))
248256
assert(skkPrefs.zenkakuKey == (KeyEvent.KEYCODE_Z shl 4 or 1))
@@ -257,6 +265,12 @@ class SKKSettingsActivityUITest {
257265
}
258266
onView(withText("Abbrevキー")).check(matches(hasSibling(withText("PERIOD"))))
259267
assert(skkPrefs.abbrevKey == (KeyEvent.KEYCODE_PERIOD shl 4))
268+
269+
// Revert them all
270+
skkPrefs.kanaKey = KeyEvent.KEYCODE_J shl 4 or /* CTRL_PRESSED */ 4
271+
skkPrefs.katakanaKey = KeyEvent.KEYCODE_Q shl 4
272+
skkPrefs.asciiKey = KeyEvent.KEYCODE_L shl 4
273+
skkPrefs.zenkakuKey = KeyEvent.KEYCODE_L shl 4 or 1
260274
}
261275

262276
@Test

app/src/main/java/jp/deadend/noname/skk/SKKPrefs.kt

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,31 @@ class SKKPrefs(context: Context) {
7171
set(value) = prefs.edit { putInt(res.getString(R.string.pref_cancel_key), value) }
7272

7373
var katakanaKey: Int
74-
get() = prefs.getInt(res.getString(R.string.pref_katakana_key), 720) // 720はq (KEYCODE_Q=45, shl 4)
74+
get() = prefs.getInt(
75+
res.getString(R.string.pref_katakana_key),
76+
720
77+
) // 720はq (KEYCODE_Q=45, shl 4)
7578
set(value) = prefs.edit { putInt(res.getString(R.string.pref_katakana_key), value) }
7679

7780
var asciiKey: Int
78-
get() = prefs.getInt(res.getString(R.string.pref_ascii_key), 640) // 640はl (KEYCODE_L=40, shl 4)
81+
get() = prefs.getInt(
82+
res.getString(R.string.pref_ascii_key),
83+
640
84+
) // 640はl (KEYCODE_L=40, shl 4)
7985
set(value) = prefs.edit { putInt(res.getString(R.string.pref_ascii_key), value) }
8086

8187
var zenkakuKey: Int
82-
get() = prefs.getInt(res.getString(R.string.pref_zenkaku_key), 641) // 641はShift+L (40 shl 4 | 1)
88+
get() = prefs.getInt(
89+
res.getString(R.string.pref_zenkaku_key),
90+
641
91+
) // 641はShift+L (40 shl 4 | 1)
8392
set(value) = prefs.edit { putInt(res.getString(R.string.pref_zenkaku_key), value) }
8493

8594
var abbrevKey: Int
86-
get() = prefs.getInt(res.getString(R.string.pref_abbrev_key), 1216) // 1216はSlash (KEYCODE_SLASH=76, shl 4)
95+
get() = prefs.getInt(
96+
res.getString(R.string.pref_abbrev_key),
97+
1216
98+
) // 1216はSlash (KEYCODE_SLASH=76, shl 4)
8799
set(value) = prefs.edit { putInt(res.getString(R.string.pref_abbrev_key), value) }
88100

89101
var useCandidatesView: Boolean

app/src/main/java/jp/deadend/noname/skk/engine/SKKEngine.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ class SKKEngine(
138138
fun processKey(keyCode: Int) = state.processKey(this, keyCode)
139139

140140
fun handleKanaKey() = state.handleKanaKey(this)
141-
141+
142142
fun handleKatakanaKey() {
143143
when (state) {
144144
SKKHiraganaState -> changeState(SKKKatakanaState)

app/src/main/res/xml/prefs_hard_key.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<androidx.preference.Preference
3535
app:iconSpaceReserved="false"
3636
app:key="@string/pref_ascii_key"
37-
app:title="直接入力キー" />
37+
app:title="ASCIIキー" />
3838
<androidx.preference.Preference
3939
app:iconSpaceReserved="false"
4040
app:key="@string/pref_zenkaku_key"

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Top-level build file where you can add configuration options common to all sub-projects/modules.
22
buildscript {
33
ext {
4-
agp_version = '9.1.1'
4+
agp_version = '9.2.0'
55
kotlin_version = '2.2.21'
66
}
77
repositories {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#Sat Jan 29 13:15:47 JST 2022
22
distributionBase=GRADLE_USER_HOME
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
44
distributionPath=wrapper/dists
55
zipStorePath=wrapper/dists
66
zipStoreBase=GRADLE_USER_HOME

0 commit comments

Comments
 (0)