Skip to content

Commit 6d2907f

Browse files
tanbroclaude
andcommitted
fix(ci): use simpler MSSQL password without special characters
Using 'YourStrongPassword123' instead of 'YourStrong@Passw0rd' to avoid URL encoding issues with the @ character in SQLAlchemy connection strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8a2481b commit 6d2907f

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/python-package.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ jobs:
8585
mssql:
8686
image: mcr.microsoft.com/mssql/server:2022-latest
8787
env:
88-
MSSQL_SA_PASSWORD: "YourStrong@Passw0rd"
88+
MSSQL_SA_PASSWORD: "YourStrongPassword123"
8989
MSSQL_PID: "Developer"
9090
ACCEPT_EULA: "Y"
9191
options: >-
92-
--health-cmd "/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P YourStrong@Passw0rd -Q 'SELECT 1'"
92+
--health-cmd "/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P YourStrongPassword123 -Q 'SELECT 1'"
9393
--health-interval 10s
9494
--health-timeout 30s
9595
--health-retries 5
@@ -163,8 +163,8 @@ jobs:
163163
- name: Run tests
164164
shell: bash
165165
env:
166-
TEST_URLS: mysql://test:test@127.0.0.1:3306/test postgresql://postgres:test@127.0.0.1:5432/ mssql+pyodbc://sa:YourStrong@Passw0rd@127.0.0.1:1433/master?driver=ODBC+Driver+18+for+SQL+Server
167-
TEST_ASYNC_URLS: mysql+aiomysql://test:test@127.0.0.1:3306/test postgresql+asyncpg://postgres:test@127.0.0.1:5432/ mssql+aioodbc://sa:YourStrong@Passw0rd@127.0.0.1:1433/master?driver=ODBC+Driver+18+for+SQL+Server
166+
TEST_URLS: mysql://test:test@127.0.0.1:3306/test postgresql://postgres:test@127.0.0.1:5432/ mssql+pyodbc://sa:YourStrongPassword123@127.0.0.1:1433/master?driver=ODBC+Driver+18+for+SQL+Server
167+
TEST_ASYNC_URLS: mysql+aiomysql://test:test@127.0.0.1:3306/test postgresql+asyncpg://postgres:test@127.0.0.1:5432/ mssql+aioodbc://sa:YourStrongPassword123@127.0.0.1:1433/master?driver=ODBC+Driver+18+for+SQL+Server
168168
# Oracle: oracle+oracledb://sys:YourStrong@Passw0rd@127.0.0.1:1521/?service_name=XEPDB1
169169
run: |
170170
uv run --no-dev coverage run -m unittest -cfv

0 commit comments

Comments
 (0)