Skip to content

Commit d9fc6ac

Browse files
authored
Merge pull request noobaa#1732 from liranmauda/liran-backport-into-5.19
[Backport into 5.19] Fix routes permission issues And Avoid updating cpu and memory in pvc template
2 parents 8652173 + ef55b3d commit d9fc6ac

4 files changed

Lines changed: 32 additions & 3 deletions

File tree

deploy/role_core.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,13 @@ rules:
4545
- securitycontextconstraints
4646
verbs:
4747
- use
48+
- apiGroups:
49+
- route.openshift.io
50+
resources:
51+
- routes
52+
verbs:
53+
- get
54+
- create
55+
- update
56+
- list
57+
- watch

pkg/backingstore/backingstore.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,9 @@ const (
247247
// Dev ENV minimal resources
248248
devEnvMinCPUString string = "500m"
249249
devEnvMinMemoryString string = "500Mi"
250+
251+
// Default volume size for pv-pool backing store
252+
defaultVolumeSize = int64(20 * 1024 * 1024 * 1024) // 20Gi=20*1024^3
250253
)
251254

252255
// CmdCreatePVPool returns a CLI command

pkg/backingstore/reconciler.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,6 @@ func (r *Reconciler) ReadSystemInfo() error {
567567
))
568568
}
569569

570-
const defaultVolumeSize = int64(20 * 1024 * 1024 * 1024) // 20Gi=20*1024^3
571570
var volumeSize int64
572571
pvPool := r.BackingStore.Spec.PVPool
573572
if pvPool.VolumeResources != nil {
@@ -1387,7 +1386,14 @@ func (r *Reconciler) updatePvcTemplate() {
13871386
} else if r.NooBaa.Spec.PVPoolDefaultStorageClass != nil {
13881387
r.PvcAgentTemplate.Spec.StorageClassName = r.NooBaa.Spec.PVPoolDefaultStorageClass
13891388
}
1390-
r.PvcAgentTemplate.Spec.Resources = *r.BackingStore.Spec.PVPool.VolumeResources
1389+
var volumeSize resource.Quantity
1390+
pvPool := r.BackingStore.Spec.PVPool
1391+
if pvPool.VolumeResources != nil {
1392+
volumeSize = pvPool.VolumeResources.Requests[corev1.ResourceStorage]
1393+
} else {
1394+
volumeSize = *resource.NewQuantity(defaultVolumeSize, resource.BinarySI)
1395+
}
1396+
r.PvcAgentTemplate.Spec.Resources.Requests[corev1.ResourceStorage] = volumeSize
13911397
r.PvcAgentTemplate.Labels = map[string]string{
13921398
"app": "noobaa",
13931399
"pool": r.BackingStore.Name,

pkg/bundle/deploy.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6501,7 +6501,7 @@ subjects:
65016501
name: custom-metrics-prometheus-adapter
65026502
`
65036503

6504-
const Sha256_deploy_role_core_yaml = "c3cfb5b87298224fd6e4e4bff32d3948ad168a0110b8569118a260739ef5d5e7"
6504+
const Sha256_deploy_role_core_yaml = "1ec420603dcec64b247852d106535a85a1a866129f78f790c2e5c9285f029ae7"
65056505

65066506
const File_deploy_role_core_yaml = `apiVersion: rbac.authorization.k8s.io/v1
65076507
kind: Role
@@ -6550,6 +6550,16 @@ rules:
65506550
- securitycontextconstraints
65516551
verbs:
65526552
- use
6553+
- apiGroups:
6554+
- route.openshift.io
6555+
resources:
6556+
- routes
6557+
verbs:
6558+
- get
6559+
- create
6560+
- update
6561+
- list
6562+
- watch
65536563
`
65546564

65556565
const Sha256_deploy_role_db_yaml = "bc7eeca1125dfcdb491ab8eb69e3dcbce9f004a467b88489f85678b3c6872cce"

0 commit comments

Comments
 (0)