test: cover URL canonicalization utilities#28
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Author
|
Quick status for review: this PR is mergeable from GitHub's side and intentionally scoped to the linked apidrift-cli issue. Validation already included in the PR body:
I also added the suggested GSSoC scoring labels in the PR body so maintainers can apply them directly if the change is accepted. |
Author
|
Hi @tanmayjoddar, this PR is still open, mergeable, and clean against the current base branch. I rechecked the repo test baseline locally ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add Jest coverage for numeric path segment canonicalization\n- verify UUID and high-entropy path segments are normalized\n- cover root path preservation and normalizeUrl query/hash removal\n\n## Validation\n- npm test -- --runInBand\n- node --check tests/utils/canonicalize.test.js\n- git diff --check\n\nCloses #3
Suggested GSSoC labels
If accepted for scoring, this should fit
gssoc,level:beginner,dx,type:testing,quality:cleanbased on the linked issue labels and the focused validation in this PR.