Skip to content

Commit 2998099

Browse files
author
Eugene Leonovich
committed
Fix DefaultConfigFactory::createRunner() and examples
1 parent d244944 commit 2998099

5 files changed

Lines changed: 10 additions & 7 deletions

File tree

examples/client/queue.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?php
22

3-
$factory = new Tarantool\JobQueue\DefaultConfigFactory();
4-
5-
return $factory->createQueue('foobar', $factory->createClient('tcp://127.0.0.1:3301'));
3+
return (new Tarantool\JobQueue\DefaultConfigFactory())
4+
->setConnectionUri('tcp://127.0.0.1:3301')
5+
->setQueueName('foobar')
6+
->createQueue();

examples/config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function __construct(Handler $handler)
1818
$this->handler = $handler;
1919
}
2020

21-
public function handle(Task $task, Queue $queue)
21+
public function handle(Task $task, Queue $queue): void
2222
{
2323
$this->handler->handle($task, $queue);
2424

examples/single_executor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
return new class implements Executor
88
{
9-
public function execute($payload, Queue $queue)
9+
public function execute($payload, Queue $queue): void
1010
{
1111
// do something with the payload
1212
}

src/DefaultConfigFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ public function setExecutorsConfigFile(string $configFile): self
7373
return $this;
7474
}
7575

76-
public function createRunner(string $executorsConfigFile = null): Runner
76+
public function createRunner(): Runner
7777
{
7878
return new ParallelRunner(
7979
$this->createQueue(),
8080
$this->createSuccessHandler(),
8181
$this->createFailureHandler(),
8282
$this->createLogger(),
83-
$executorsConfigFile
83+
$this->executorsConfigFile
8484
);
8585
}
8686

src/Executor/ExecutorChain.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ public function execute($payload, Queue $queue): void
3131
foreach ($this->executors as $executor) {
3232
try {
3333
$executor->execute($payload, $queue);
34+
35+
return;
3436
} catch (BadPayloadException $e) {
3537
// try next executor
3638
}

0 commit comments

Comments
 (0)