-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathconfig_coverage_test.go
More file actions
417 lines (318 loc) · 10.4 KB
/
config_coverage_test.go
File metadata and controls
417 lines (318 loc) · 10.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
package config_test
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/tarantool/go-config"
"github.com/tarantool/go-config/collectors"
"github.com/tarantool/go-config/tree"
"github.com/tarantool/go-config/validator"
)
// alwaysFailingValidator that always fails.
type alwaysFailingValidator struct{}
func (m *alwaysFailingValidator) Validate(_ *tree.Node) []validator.ValidationError {
return []validator.ValidationError{
{
Path: config.NewKeyPath("test"),
Range: validator.NewEmptyRange(),
Code: "test",
Message: "always fails",
},
}
}
func (m *alwaysFailingValidator) SchemaType() string {
return "always-failing"
}
// maxKeysValidator fails validation when number of keys exceeds limit.
type maxKeysValidator struct {
maxKeys int
}
func (m *maxKeysValidator) Validate(root *tree.Node) []validator.ValidationError {
if root == nil {
return nil
}
if len(root.Children()) > m.maxKeys {
return []validator.ValidationError{
{
Path: config.NewKeyPath(""),
Range: validator.NewEmptyRange(),
Code: "too-many-keys",
Message: "too many keys",
},
}
}
return nil
}
func (m *maxKeysValidator) SchemaType() string {
return "max-keys"
}
// valueChangeValidator fails when key "key" value is not "original".
type valueChangeValidator struct{}
func (v *valueChangeValidator) Validate(root *tree.Node) []validator.ValidationError {
if root == nil {
return nil
}
child := root.Child("key")
if child == nil {
return nil
}
if child.Value != "original" {
return []validator.ValidationError{
{
Path: config.NewKeyPath("key"),
Range: validator.NewEmptyRange(),
Code: "value-changed",
Message: "value must be 'original'",
},
}
}
return nil
}
func (v *valueChangeValidator) SchemaType() string {
return "value-change"
}
// minKeysValidator fails validation when number of keys is below minimum.
type minKeysValidator struct {
minKeys int
}
func (m *minKeysValidator) Validate(root *tree.Node) []validator.ValidationError {
if root == nil {
return nil
}
if len(root.Children()) < m.minKeys {
return []validator.ValidationError{
{
Path: config.NewKeyPath(""),
Range: validator.NewEmptyRange(),
Code: "too-few-keys",
Message: "too few keys",
},
}
}
return nil
}
func (m *minKeysValidator) SchemaType() string {
return "min-keys"
}
func TestConfig_Get_MissingKey(t *testing.T) {
t.Parallel()
data := map[string]any{
"existing": 42,
}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.Empty(t, errs)
var dest int
_, err := cfg.Get(config.NewKeyPath("missing"), &dest)
require.Error(t, err)
assert.ErrorContains(t, err, "key not found")
}
func TestConfig_Get_TypeMismatchError(t *testing.T) {
t.Parallel()
data := map[string]any{
"port": []any{1, 2},
}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.Empty(t, errs)
var dest int
_, err := cfg.Get(config.NewKeyPath("port"), &dest)
require.Error(t, err)
t.Logf("conversion error: %v", err)
}
func TestConfig_Stat_NilRoot(t *testing.T) {
t.Parallel()
validator := &alwaysFailingValidator{}
data := map[string]any{"x": 1}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.NotNil(t, errs)
meta, ok := cfg.Stat(config.NewKeyPath("any"))
assert.False(t, ok)
assert.Empty(t, meta.Source.Name)
assert.Equal(t, config.UnknownSource, meta.Source.Type)
}
func TestConfig_Walk_NilRoot(t *testing.T) {
t.Parallel()
validator := &alwaysFailingValidator{}
data := map[string]any{"x": 1}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.NotNil(t, errs)
ctx := context.Background()
_, err := cfg.Walk(ctx, config.NewKeyPath(""), -1)
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}
func TestMutableConfig_Update_ValidationError(t *testing.T) {
t.Parallel()
// Create mutable config with validator that fails when key "key" value changes.
v := &valueChangeValidator{}
data := map[string]any{"key": "original"}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(v)
builder = builder.AddCollector(col)
mcfg, errs := builder.BuildMutable(t.Context())
require.Empty(t, errs)
// Create other config with updated value for existing key.
otherData := map[string]any{"key": "newvalue"}
col2 := collectors.NewMap(otherData)
builder2 := config.NewBuilder()
builder2 = builder2.AddCollector(col2)
otherCfg, errs2 := builder2.Build(t.Context())
require.Empty(t, errs2)
// Update should fail due to validation error.
err := mcfg.Update(&otherCfg)
require.Error(t, err)
assert.ErrorContains(t, err, "value must be 'original'")
}
func TestConfig_Slice_NilRootNonEmptyPath(t *testing.T) {
t.Parallel()
validator := &alwaysFailingValidator{}
data := map[string]any{"x": 1}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.NotNil(t, errs)
// Slice with non-empty path on nil root should error.
_, err := cfg.Slice(config.NewKeyPath("some/path"))
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}
func TestMutableConfig_Merge_WalkError(t *testing.T) {
t.Parallel()
// Create valid mutable config.
validData := map[string]any{"key": "value"}
col := collectors.NewMap(validData)
builder := config.NewBuilder()
builder = builder.AddCollector(col)
mcfg, errs := builder.BuildMutable(t.Context())
require.Empty(t, errs)
// Create invalid config with nil root (validation failure).
validator := &alwaysFailingValidator{}
invalidData := map[string]any{"x": 1}
col2 := collectors.NewMap(invalidData)
builder2 := config.NewBuilder()
builder2 = builder2.WithValidator(validator)
builder2 = builder2.AddCollector(col2)
invalidCfg, errs2 := builder2.Build(t.Context())
require.NotNil(t, errs2) // Validation errors, root is nil.
// Merge should fail because Walk on invalid config returns error.
err := mcfg.Merge(&invalidCfg)
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}
func TestMutableConfig_Merge_ValidationError(t *testing.T) {
t.Parallel()
// Use maxKeysValidator that fails when more than 1 key present.
validator := &maxKeysValidator{maxKeys: 1}
data := map[string]any{"key": "value"}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
mcfg, errs := builder.BuildMutable(t.Context())
require.Empty(t, errs)
// Sanity check: validator is attached and works for Set.
err := mcfg.Set(config.NewKeyPath("secondkey"), "value")
require.Error(t, err)
require.ErrorContains(t, err, "too many keys")
// Build other config with newkey.
otherData := map[string]any{"newkey": "newvalue"}
col2 := collectors.NewMap(otherData)
builder2 := config.NewBuilder()
builder2 = builder2.AddCollector(col2)
otherCfg, errs2 := builder2.Build(t.Context())
require.Empty(t, errs2)
// Verify other config contains newkey.
_, ok := otherCfg.Lookup(config.NewKeyPath("newkey"))
assert.True(t, ok)
// Merge should fail due to validation error.
err = mcfg.Merge(&otherCfg)
require.Error(t, err)
assert.ErrorContains(t, err, "too many keys")
}
func TestMutableConfig_Update_WalkError(t *testing.T) {
t.Parallel()
// Create valid mutable config.
validData := map[string]any{"key": "value"}
col := collectors.NewMap(validData)
builder := config.NewBuilder()
builder = builder.AddCollector(col)
mcfg, errs := builder.BuildMutable(t.Context())
require.Empty(t, errs)
// Create invalid config with nil root (validation failure).
validator := &alwaysFailingValidator{}
invalidData := map[string]any{"x": 1}
col2 := collectors.NewMap(invalidData)
builder2 := config.NewBuilder()
builder2 = builder2.WithValidator(validator)
builder2 = builder2.AddCollector(col2)
invalidCfg, errs2 := builder2.Build(t.Context())
require.NotNil(t, errs2) // Validation errors, root is nil.
// Update should fail because Walk on invalid config returns error.
err := mcfg.Update(&invalidCfg)
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}
func TestConfig_Walk_NonExistentPath(t *testing.T) {
t.Parallel()
data := map[string]any{"key": "value"}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.Empty(t, errs)
ctx := context.Background()
_, err := cfg.Walk(ctx, config.NewKeyPath("nonexistent"), -1)
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}
// TestConfig_Walk_CtxCancelled removed; see TestWalkNodes_CtxCancelled in inheritance_internal_test.go.
func TestConfig_Slice_NilRootEmptyPath(t *testing.T) {
t.Parallel()
// Create config with nil root (validation failure).
validator := &alwaysFailingValidator{}
data := map[string]any{"x": 1}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.NotNil(t, errs) // Validation errors, root is nil.
// Slice with empty path should return config with nil root (no error).
sliced, err := cfg.Slice(config.NewKeyPath(""))
require.NoError(t, err)
// Attempt to get a value from sliced config (should return not found).
_, ok := sliced.Lookup(config.NewKeyPath("any"))
assert.False(t, ok)
}
func TestConfig_Effective_NilRoot(t *testing.T) {
t.Parallel()
// Config with nil root.
validator := &alwaysFailingValidator{}
data := map[string]any{"x": 1}
col := collectors.NewMap(data)
builder := config.NewBuilder()
builder = builder.WithValidator(validator)
builder = builder.AddCollector(col)
cfg, errs := builder.Build(t.Context())
require.NotNil(t, errs) // Validation errors, root is nil.
_, err := cfg.Effective(config.NewKeyPath("any"))
require.Error(t, err)
assert.ErrorContains(t, err, "path not found")
}