ci: bump golangci-lint to v2

Only the linters that were previously included were enabled. The
disabled linters will be enabled later, one by one.

Author: oleg-jukovec

.github/workflows/check.yaml

@@ -43,18 +43,9 @@ jobs:
       - uses: actions/checkout@v5
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
-        continue-on-error: true
+        uses: golangci/golangci-lint-action@v9
         with:
-          # The first run is for GitHub Actions error format.
-          args: --config=.golangci.yaml
-
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
-        with:
-          # The second run is for human-readable error format with a file name
-          # and a line number.
-          args: --out-${NO_FUTURE}format colored-line-number --config=.golangci.yaml
+          args: --config=.golangci.yml
 
   codespell:
     runs-on: ubuntu-24.04

.golangci.yaml

@@ -0,0 +1,86 @@
+version: "2"
+
+formatters:
+  enable:
+    - goimports
+
+linters:
+  default: all
+  settings:
+    lll:
+      line-length: 100
+  exclusions:
+    rules:
+      - linters:
+          - lll
+        source: "^//go:generate "
+      - linters:
+          - lll
+        source: "https?://"
+  disable:
+    - containedctx
+    - contextcheck
+    - copyloopvar
+    - cyclop
+    - depguard
+    - dupl
+    - dupword
+    - embeddedstructfieldcheck
+    - err113
+    - errname
+    - errorlint
+    - exhaustive
+    - exhaustruct
+    - fatcontext
+    - forcetypeassert
+    - funcorder
+    - funlen
+    - gochecknoglobals
+    - gochecknoinits
+    - gocognit
+    - goconst
+    - gocyclo
+    - godoclint
+    - godox
+    - gosec
+    - gosmopolitan
+    - iface
+    - inamedparam
+    - interfacebloat
+    - intrange
+    - ireturn
+    - maintidx
+    - makezero
+    - mirror
+    - misspell
+    - mnd
+    - modernize
+    - nakedret
+    - nestif
+    - nilerr
+    - nilnil
+    - nlreturn
+    - noctx
+    - noinlineerr
+    - nolintlint
+    - nonamedreturns
+    - paralleltest
+    - perfsprint
+    - prealloc
+    - predeclared
+    - recvcheck
+    - revive
+    - staticcheck
+    - tparallel
+    - testableexamples
+    - testifylint
+    - testpackage
+    - thelper
+    - unparam
+    - unqueryvet
+    - varnamelen
+    - wastedassign
+    - whitespace
+    - wrapcheck
+    - wsl
+    - wsl_v5

.golangci.yml

@@ -36,7 +36,7 @@ format:
 
 .PHONY: golangci-lint
 golangci-lint:
-	golangci-lint run --config=.golangci.yaml
+	golangci-lint run --max-same-issues 0 --max-issues-per-linter 100
 
 .PHONY: test
 test:

Makefile

@@ -60,7 +60,7 @@ func TestInsert_invalid(t *testing.T) {
 	}
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	for i, a := range arrows {
 		t.Run(strconv.Itoa(i), func(t *testing.T) {

arrow/tarantool_test.go

@@ -21,7 +21,7 @@ const (
 	AutoAuth Auth = iota
 	// ChapSha1Auth forces chap-sha1 authentication method. The method is
 	// available both in the Tarantool Community Edition (CE) and the
-	// Tarantool Enterprise Edition (EE)
+	// Tarantool Enterprise Edition (EE).
 	ChapSha1Auth
 	// PapSha256Auth forces pap-sha256 authentication method. The method is
 	// available only for the Tarantool Enterprise Edition (EE) with

auth.go

@@ -26,7 +26,7 @@ const (
 // MP_ERROR_STACK object with a link to the previous stack error.
 // See https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_error/error/
 //
-// Since 1.10.0
+// Since 1.10.0.
 type BoxError struct {
 	// Type is error type that implies its source (for example, "ClientError").
 	Type string

boxerror.go

@@ -300,7 +300,7 @@ func TestErrorTypeEval(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	for name, testcase := range tupleCases {
 		t.Run(name, func(t *testing.T) {
@@ -321,7 +321,7 @@ func TestErrorTypeEvalTyped(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	for name, testcase := range tupleCases {
 		t.Run(name, func(t *testing.T) {
@@ -341,7 +341,7 @@ func TestErrorTypeInsert(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	truncateEval := fmt.Sprintf("box.space[%q]:truncate()", space)
 	_, err := conn.Do(NewEvalRequest(truncateEval).Args([]interface{}{})).Get()
@@ -379,7 +379,7 @@ func TestErrorTypeInsertTyped(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	truncateEval := fmt.Sprintf("box.space[%q]:truncate()", space)
 	_, err := conn.Do(NewEvalRequest(truncateEval).Args([]interface{}{})).Get()
@@ -421,7 +421,7 @@ func TestErrorTypeSelect(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	truncateEval := fmt.Sprintf("box.space[%q]:truncate()", space)
 	_, err := conn.Do(NewEvalRequest(truncateEval).Args([]interface{}{})).Get()
@@ -470,7 +470,7 @@ func TestErrorTypeSelectTyped(t *testing.T) {
 	test_helpers.SkipIfErrorMessagePackTypeUnsupported(t)
 
 	conn := test_helpers.ConnectWithValidation(t, dialer, opts)
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	truncateEval := fmt.Sprintf("box.space[%q]:truncate()", space)
 	_, err := conn.Do(NewEvalRequest(truncateEval).Args([]interface{}{})).Get()

boxerror_test.go

@@ -278,7 +278,7 @@ const (
 	RLimitWait
 )
 
-// Opts is a way to configure Connection
+// Opts is a way to configure Connection.
 type Opts struct {
 	// Timeout for response to a particular request. The timeout is reset when
 	// push messages are received. If Timeout is zero, any request can be
@@ -499,7 +499,7 @@ func (conn *Connection) dial(ctx context.Context) error {
 	})
 
 	if err != nil {
-		c.Close()
+		_ = c.Close()
 		return fmt.Errorf("unable to register watch: %w", err)
 	}
 
@@ -900,7 +900,8 @@ func (conn *Connection) reader(r io.Reader, c Conn) {
 			return
 		}
 
-		if code == iproto.IPROTO_EVENT {
+		switch code {
+		case iproto.IPROTO_EVENT:
 			if event, err := readWatchEvent(&buf); err == nil {
 				events <- event
 			} else {
@@ -910,10 +911,9 @@ func (conn *Connection) reader(r io.Reader, c Conn) {
 				}
 				conn.opts.Logger.Report(LogWatchEventReadFailed, conn, err)
 			}
-			continue
-		} else if code == iproto.IPROTO_CHUNK {
+		case iproto.IPROTO_CHUNK:
 			conn.opts.Logger.Report(LogBoxSessionPushUnsupported, conn, header)
-		} else {
+		default:
 			resps <- resp{header: header, buf: buf}
 		}
 	}
@@ -1298,7 +1298,8 @@ func (conn *Connection) NewPrepared(expr string) (*Prepared, error) {
 //
 // Since v. 2.10.0, Tarantool supports streams and interactive transactions over them.
 // To use interactive transactions, memtx_use_mvcc_engine box option should be set to true.
-// Since 1.7.0
+//
+// Since 1.7.0.
 func (conn *Connection) NewStream() (*Stream, error) {
 	next := atomic.AddUint64(&conn.lastStreamId, 1)
 	return &Stream{
@@ -1445,7 +1446,7 @@ func isFeatureInSlice(expected iproto.Feature, actualSlice []iproto.Feature) boo
 // See:
 // https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_events/#box-watchers
 //
-// Since 1.10.0
+// Since 1.10.0.
 func (conn *Connection) NewWatcher(key string, callback WatchCallback) (Watcher, error) {
 	// We need to check the feature because the IPROTO_WATCH request is
 	// asynchronous. We do not expect any response from a Tarantool instance
@@ -1548,7 +1549,8 @@ func (conn *Connection) newWatcherImpl(key string, callback WatchCallback) (Watc
 // ProtocolInfo returns protocol version and protocol features
 // supported by connected Tarantool server. Beware that values might be
 // outdated if connection is in a disconnected state.
-// Since 2.0.0
+//
+// Since 2.0.0.
 func (conn *Connection) ProtocolInfo() ProtocolInfo {
 	return conn.serverProtocolInfo.Clone()
 }

connection.go

@@ -139,23 +139,24 @@ func (r *Result) DecodeMsgpack(d *msgpack.Decoder) error {
 			return err
 		}
 
-		if msgpackIsArray(code) {
+		switch {
+		case msgpackIsArray(code):
 			crudErr := newErrorMany(r.rowType)
 			if err := d.Decode(&crudErr); err != nil {
 				return err
 			}
 			if crudErr != nil {
 				return *crudErr
 			}
-		} else if code != msgpcode.Nil {
+		case code != msgpcode.Nil:
 			crudErr := newError(r.rowType)
 			if err := d.Decode(&crudErr); err != nil {
 				return err
 			}
 			if crudErr != nil {
 				return *crudErr
 			}
-		} else {
+		default:
 			if err := d.DecodeNil(); err != nil {
 				return err
 			}