tests: migrate datetime package to testify#569
Merged
oleg-jukovec merged 1 commit intomasterfrom Apr 21, 2026
Merged
Conversation
The datetime package tests used a mix of standard testing package assertions (t.Fatal, t.Errorf) and testify. This inconsistency made the code harder to read and maintain. Migrated all assertions to testify (require for fatal errors, assert for non-fatal), improving test readability and consistency with other packages.
sssciel
approved these changes
Apr 20, 2026
Mockird31
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datetime package tests used a mix of standard testing package
assertions (t.Fatal, t.Errorf) and testify. This inconsistency
made the code harder to read and maintain.
Migrated all assertions to testify (require for fatal errors,
assert for non-fatal), improving test readability and
consistency with other packages.