tests: fix flaky TestConnectionHandlerUpdateError#573
Merged
oleg-jukovec merged 1 commit intomasterfrom Apr 20, 2026
Merged
Conversation
The test set servers to read_only one-by-one via pool connections with pool.RW mode, but the background checker (with 100µs timeout) could detect the role change and close the connection before the next iteration found an RW server, causing "connection closed by client" errors. Now SetClusterRO is used to set both servers read_only directly, bypassing the pool and avoiding the race.
sssciel
approved these changes
Apr 16, 2026
Mockird31
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test set servers to read_only one-by-one via pool connections with pool.RW mode, but the background checker (with 100µs timeout) could detect the role change and close the connection before the next iteration found an RW server, causing "connection closed by client" errors.
Now SetClusterRO is used to set both servers read_only directly, bypassing the pool and avoiding the race.