v3: refactoring on test_helpers/pool_helper.go#576
Merged
oleg-jukovec merged 7 commits intomasterfrom Apr 24, 2026
Merged
Conversation
oleg-jukovec
force-pushed
the
laines-it/gh-485-test-helpers-improve
branch
from
cf0146e to
0f34d40
Compare
Using switch over chained if/else for grouped validations. Using errors.New and fmt.Errorf with %w for proper error wrapping Part of #485
Used GetTyped(&data) instead Get() for expected type. Part of #485
Added comparePortMaps for deep comparing map[string]bool. Used in ProcessListenOnInstance. Part of #485
New pattern look like this:
```
assert.Eventually(t, func() bool {
err = f(args)
return err == nil
}, defaultTimeoutRetry, defaultTickRetry)
```
Part of #485
InsertOnInstances and SetClusterRO use ExecuteOnAll to execute on all instances in parallel. Minor changes: * checkRole in SetInstanceRO returns error instead string. * structured box API instead of raw CallRequest used in checkRole. Part of #485
Changed signature of
ProcessListenOnInstance and ListenOnInstanceArgs
using ListenOnInstanceArgs and CheckStatusesArgs
instead of interface{}.
Closes #485
oleg-jukovec
force-pushed
the
laines-it/gh-485-test-helpers-improve
branch
from
0f34d40 to
19c1e8e
Compare
oleg-jukovec
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
Closes #485