Add id field to the builder

Author: LLDay

crates/iceberg/src/transaction/update_schema.rs

@@ -48,6 +48,8 @@ pub struct AddColumn {
     #[builder(default = false)]
     required: bool,
     field_type: Type,
+    #[builder(default = None)]
+    id: Option<i32>,
     #[builder(default = None, setter(strip_option, into))]
     doc: Option<String>,
     #[builder(default = None, setter(strip_option))]
@@ -91,7 +93,7 @@ impl AddColumn {
 
     fn to_nested_field(&self) -> NestedFieldRef {
         let mut field = NestedField::new(
-            DEFAULT_ID,
+            self.id.unwrap_or(DEFAULT_ID),
             self.name.clone(),
             self.field_type.clone(),
             self.required,
@@ -457,7 +459,7 @@ impl TransactionAction for UpdateSchemaAction {
             };
 
             // Assign fresh IDs immediately, preserving insertion order.
-            let field = if self.auto_assign_ids {
+            let field = if self.auto_assign_ids && pending_field.id == DEFAULT_ID {
                 assign_fresh_ids(&pending_field, &mut last_column_id)
             } else {
                 pending_field
@@ -503,6 +505,7 @@ mod tests {
 
     use as_any::Downcast;
 
+    use crate::io::FileIOBuilder;
     use crate::spec::{Literal, NestedField, PrimitiveType, StructType, TableMetadata, Type};
     use crate::table::Table;
     use crate::transaction::Transaction;
@@ -608,7 +611,7 @@ mod tests {
             .metadata(metadata)
             .metadata_location("s3://bucket/test/location/metadata/v1.json".to_string())
             .identifier(TableIdent::from_strs(["ns1", "test1"]).unwrap())
-            .file_io(crate::io::FileIO::new_with_memory())
+            .file_io(FileIOBuilder::new("memory").build().unwrap())
             .build()
             .unwrap()
     }
@@ -657,9 +660,12 @@ mod tests {
 
         // Verify requirement.
         assert_eq!(requirements.len(), 1);
-        assert_eq!(requirements[0], TableRequirement::CurrentSchemaIdMatch {
-            current_schema_id: table.metadata().current_schema().schema_id()
-        });
+        assert_eq!(
+            requirements[0],
+            TableRequirement::CurrentSchemaIdMatch {
+                current_schema_id: table.metadata().current_schema().schema_id()
+            }
+        );
     }
 
     #[tokio::test]