feat(Datum): allow to cast from Double to Float#11
Merged
askalt merged 1 commit intodf-52.3.0-release-bindingfrom Apr 21, 2026
Merged
Conversation
LLDay
reviewed
Apr 14, 2026
novartole
force-pushed
the
aonovikov/feat/datum_long_to_float_converting
branch
from
c63a159 to
428d453
Compare
novartole
force-pushed
the
aonovikov/feat/datum_long_to_float_converting
branch
from
428d453 to
f2d83f9
Compare
kryvashek
approved these changes
Apr 17, 2026
Member
kryvashek
left a comment
kryvashek
left a comment
There was a problem hiding this comment.
My only comment isn't critical, hence approved.
Comment on lines
+51
to
+52
| pub(crate) const FLOAT_MAX: f32 = 3.4028235e38; | ||
| pub(crate) const FLOAT_MIN: f32 = -3.4028235e38; |
Member
There was a problem hiding this comment.
Why not
Suggested change
| pub(crate) const FLOAT_MAX: f32 = 3.4028235e38; | |
| pub(crate) const FLOAT_MIN: f32 = -3.4028235e38; | |
| pub(crate) const FLOAT_MAX: f64 = f32::MAX as f64; | |
| pub(crate) const FLOAT_MIN: f64 = f32::MIN as f64; |
?
Less chance of error + already casted to required type (may remove in-code casts in that case).
Author
There was a problem hiding this comment.
That absolutely makes sense. IDK why in the original code source this approach is used for other constants. I decided to keep this weird style for this part too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Extend
Datum::towithDoubletoFloatcast.Are these changes tested?
A unit-test is added.