Skip to content

feat: rollback to snapshot action#8

Merged
LLDay merged 1 commit into
df-52.3.0-release-bindingfrom
dsemenov/rollback-to-snapshot
Apr 8, 2026
Merged

feat: rollback to snapshot action#8
LLDay merged 1 commit into
df-52.3.0-release-bindingfrom
dsemenov/rollback-to-snapshot

Conversation

@LLDay
Copy link
Copy Markdown

@LLDay LLDay commented Mar 18, 2026

What changes are included in this PR?

Added the rollback to snapshot action.

Are these changes tested?

Yes, unit tests.

@kryvashek
Copy link
Copy Markdown
Member

Don't you want to move as much changes as possible into separate extansions module, like it is done in sql and datafusion? At least to keep it consistent.

@LLDay
Copy link
Copy Markdown
Author

LLDay commented Mar 19, 2026

Don't you want to move as much changes as possible into separate extansions module, like it is done in sql and datafusion?

The transaction module contains many submodules that represent actions:

├── action.rs
├── append.rs
├── mod.rs
├── rollback_to_snapshot.rs
├── snapshot.rs
├── sort_order.rs
├── update_location.rs
├── update_properties.rs
├── update_statistics.rs
└── upgrade_format_version.rs

Our module matches to this style. Rollback is a functionality that is needed not only for our purposes, it is also implemented in the iceberg-python repository, so theoretically we can do PR in the upstream and they will wonder why the new action is in the extension module.

@LLDay
Copy link
Copy Markdown
Author

LLDay commented Mar 19, 2026

@kryvashek, could you review the changes if you've already started watching.

@LLDay LLDay requested a review from kryvashek March 19, 2026 07:59
@LLDay LLDay changed the base branch from df-42-release-binding to askalt/new-bump-candidate April 6, 2026 08:39
@LLDay LLDay force-pushed the dsemenov/rollback-to-snapshot branch 2 times, most recently from 4fd8539 to e4a7f2a Compare April 6, 2026 09:12
@kryvashek
Copy link
Copy Markdown
Member

@kryvashek, could you review the changes if you've already started watching.

Somehow I've missed this. Ok, sure, will do.

Comment thread crates/iceberg/src/transaction/rollback_to_snapshot.rs Outdated
Comment thread crates/iceberg/src/transaction/rollback_to_snapshot.rs Outdated
@LLDay LLDay force-pushed the dsemenov/rollback-to-snapshot branch from e4a7f2a to b39f11e Compare April 8, 2026 07:29
@LLDay LLDay changed the base branch from askalt/new-bump-candidate to df-52.3.0-release-binding April 8, 2026 07:32
@LLDay LLDay merged commit 8d65084 into df-52.3.0-release-binding Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants