Skip to content

Commit 519dbbe

Browse files
committed
feat(testcontainers): refactor vshard and cartridge containers
1 parent ed7c898 commit 519dbbe

File tree

18 files changed

+178
-283
lines changed

18 files changed

+178
-283
lines changed

tarantool-client/src/test/java/io/tarantool/client/integration/TarantoolCrudClientTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import com.fasterxml.jackson.core.type.TypeReference;
3535
import org.junit.jupiter.api.BeforeAll;
3636
import org.junit.jupiter.api.BeforeEach;
37-
import org.junit.jupiter.api.Disabled;
3837
import org.junit.jupiter.api.Test;
3938
import org.junit.jupiter.api.Timeout;
4039
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
@@ -45,8 +44,8 @@
4544
import org.junit.jupiter.params.provider.MethodSource;
4645
import org.msgpack.value.ValueFactory;
4746
import org.slf4j.LoggerFactory;
47+
import org.testcontainers.containers.ClusterContainer;
4848
import org.testcontainers.containers.TarantoolCartridgeContainer;
49-
import org.testcontainers.containers.TarantoolContainerOperations;
5049
import org.testcontainers.containers.VshardClusterContainer;
5150
import org.testcontainers.containers.output.Slf4jLogConsumer;
5251
import org.testcontainers.junit.jupiter.Testcontainers;
@@ -86,7 +85,6 @@
8685
import io.tarantool.pool.IProtoClientPool;
8786
import io.tarantool.pool.InstanceConnectionGroup;
8887

89-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
9088
@Timeout(value = 10)
9189
@Testcontainers
9290
public class TarantoolCrudClientTest extends BaseTest {
@@ -103,7 +101,7 @@ public class TarantoolCrudClientTest extends BaseTest {
103101
public static final Person STUB_PERSON = new Person(0, true, String.valueOf(0));
104102
private static TarantoolCartridgeContainer cartridgeContainer;
105103
private static VshardClusterContainer vshardClusterContainer;
106-
private static TarantoolContainerOperations clusterContainer;
104+
private static ClusterContainer clusterContainer;
107105
public static final String ROUTER_1 = "ROUTER_1";
108106
public static final String ROUTER_2 = "ROUTER_2";
109107
private static TarantoolCrudClient client;

tarantool-client/src/test/java/io/tarantool/client/integration/TarantoolCrudClientWithRetryTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import org.junit.jupiter.api.AfterEach;
2222
import org.junit.jupiter.api.BeforeAll;
2323
import org.junit.jupiter.api.BeforeEach;
24-
import org.junit.jupiter.api.Disabled;
2524
import org.junit.jupiter.api.Test;
2625
import org.junit.jupiter.api.Timeout;
2726
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
@@ -36,7 +35,6 @@
3635
import io.tarantool.core.exceptions.BoxError;
3736
import io.tarantool.mapping.Tuple;
3837

39-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
4038
@Timeout(value = 5)
4139
@Testcontainers
4240
public class TarantoolCrudClientWithRetryTest {

tarantool-spring-data/tarantool-spring-data-27/src/test/java/io/tarantool/spring/data27/integration/BaseIntegrationTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
import org.junit.jupiter.api.AfterAll;
1313
import org.junit.jupiter.api.BeforeAll;
14-
import org.junit.jupiter.api.Disabled;
1514
import org.junit.jupiter.api.Timeout;
1615
import org.slf4j.LoggerFactory;
16+
import org.testcontainers.containers.ClusterContainer;
1717
import org.testcontainers.containers.TarantoolCartridgeContainer;
18-
import org.testcontainers.containers.TarantoolContainerOperations;
1918
import org.testcontainers.containers.VshardClusterContainer;
2019
import org.testcontainers.containers.output.Slf4jLogConsumer;
2120

@@ -24,11 +23,10 @@
2423
import static io.tarantool.spring.data27.utils.TarantoolTestSupport.writeTestPropertiesYaml;
2524
import io.tarantool.spring.data27.config.properties.TarantoolProperties;
2625

27-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
2826
@Timeout(60)
2927
public abstract class BaseIntegrationTest {
3028

31-
protected static TarantoolContainerOperations<?> clusterContainer;
29+
protected static ClusterContainer clusterContainer;
3230

3331
private static final String dockerRegistry =
3432
System.getenv().getOrDefault("TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX", "");

tarantool-spring-data/tarantool-spring-data-27/src/test/java/io/tarantool/spring/data27/integration/crud/CrudConfigurations.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414
import org.junit.jupiter.api.BeforeAll;
1515
import org.junit.jupiter.api.BeforeEach;
16-
import org.junit.jupiter.api.Disabled;
1716
import org.junit.jupiter.api.Test;
1817
import org.springframework.beans.factory.annotation.Autowired;
1918
import org.springframework.context.annotation.Bean;
@@ -34,7 +33,6 @@
3433
import io.tarantool.spring.data27.integration.BaseIntegrationTest;
3534
import io.tarantool.spring.data27.repository.config.EnableTarantoolRepositories;
3635

37-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
3836
@TestPropertySource(properties = {DEFAULT_PROPERTY_FILE_LOCATION_CLASSPATH})
3937
abstract class CrudConfigurations extends BaseIntegrationTest {
4038

tarantool-spring-data/tarantool-spring-data-31/src/test/java/io/tarantool/spring/data31/integration/BaseIntegrationTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
import org.junit.jupiter.api.AfterAll;
1313
import org.junit.jupiter.api.BeforeAll;
14-
import org.junit.jupiter.api.Disabled;
1514
import org.junit.jupiter.api.Timeout;
1615
import org.slf4j.LoggerFactory;
16+
import org.testcontainers.containers.ClusterContainer;
1717
import org.testcontainers.containers.TarantoolCartridgeContainer;
18-
import org.testcontainers.containers.TarantoolContainerOperations;
1918
import org.testcontainers.containers.VshardClusterContainer;
2019
import org.testcontainers.containers.output.Slf4jLogConsumer;
2120

@@ -24,11 +23,10 @@
2423
import static io.tarantool.spring.data31.utils.TarantoolTestSupport.writeTestPropertiesYaml;
2524
import io.tarantool.spring.data31.config.properties.TarantoolProperties;
2625

27-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
2826
@Timeout(60)
2927
public abstract class BaseIntegrationTest {
3028

31-
protected static TarantoolContainerOperations<?> clusterContainer;
29+
protected static ClusterContainer clusterContainer;
3230

3331
private static final String dockerRegistry =
3432
System.getenv().getOrDefault("TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX", "");

tarantool-spring-data/tarantool-spring-data-31/src/test/java/io/tarantool/spring/data31/integration/crud/CrudConfigurations.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414
import org.junit.jupiter.api.BeforeAll;
1515
import org.junit.jupiter.api.BeforeEach;
16-
import org.junit.jupiter.api.Disabled;
1716
import org.junit.jupiter.api.Test;
1817
import org.springframework.beans.factory.annotation.Autowired;
1918
import org.springframework.context.annotation.Bean;
@@ -34,7 +33,6 @@
3433
import io.tarantool.spring.data31.integration.BaseIntegrationTest;
3534
import io.tarantool.spring.data31.repository.config.EnableTarantoolRepositories;
3635

37-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
3836
@TestPropertySource(properties = {DEFAULT_PROPERTY_FILE_LOCATION_CLASSPATH})
3937
abstract class CrudConfigurations extends BaseIntegrationTest {
4038

tarantool-spring-data/tarantool-spring-data-32/src/test/java/io/tarantool/spring/data32/integration/BaseIntegrationTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
import org.junit.jupiter.api.AfterAll;
1313
import org.junit.jupiter.api.BeforeAll;
14-
import org.junit.jupiter.api.Disabled;
1514
import org.junit.jupiter.api.Timeout;
1615
import org.slf4j.LoggerFactory;
16+
import org.testcontainers.containers.ClusterContainer;
1717
import org.testcontainers.containers.TarantoolCartridgeContainer;
18-
import org.testcontainers.containers.TarantoolContainerOperations;
1918
import org.testcontainers.containers.VshardClusterContainer;
2019
import org.testcontainers.containers.output.Slf4jLogConsumer;
2120

@@ -24,11 +23,10 @@
2423
import static io.tarantool.spring.data32.utils.TarantoolTestSupport.writeTestPropertiesYaml;
2524
import io.tarantool.spring.data32.config.properties.TarantoolProperties;
2625

27-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
2826
@Timeout(60)
2927
public abstract class BaseIntegrationTest {
3028

31-
protected static TarantoolContainerOperations<?> clusterContainer;
29+
protected static ClusterContainer clusterContainer;
3230

3331
private static final String dockerRegistry =
3432
System.getenv().getOrDefault("TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX", "");

tarantool-spring-data/tarantool-spring-data-32/src/test/java/io/tarantool/spring/data32/integration/crud/CrudConfigurations.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414
import org.junit.jupiter.api.BeforeAll;
1515
import org.junit.jupiter.api.BeforeEach;
16-
import org.junit.jupiter.api.Disabled;
1716
import org.junit.jupiter.api.Test;
1817
import org.springframework.beans.factory.annotation.Autowired;
1918
import org.springframework.context.annotation.Bean;
@@ -34,7 +33,6 @@
3433
import io.tarantool.spring.data32.integration.BaseIntegrationTest;
3534
import io.tarantool.spring.data32.repository.config.EnableTarantoolRepositories;
3635

37-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
3836
@TestPropertySource(properties = {DEFAULT_PROPERTY_FILE_LOCATION_CLASSPATH})
3937
abstract class CrudConfigurations extends BaseIntegrationTest {
4038

tarantool-spring-data/tarantool-spring-data-33/src/test/java/io/tarantool/spring/data33/integration/BaseIntegrationTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
import org.junit.jupiter.api.AfterAll;
1313
import org.junit.jupiter.api.BeforeAll;
14-
import org.junit.jupiter.api.Disabled;
1514
import org.junit.jupiter.api.Timeout;
1615
import org.slf4j.LoggerFactory;
16+
import org.testcontainers.containers.ClusterContainer;
1717
import org.testcontainers.containers.TarantoolCartridgeContainer;
18-
import org.testcontainers.containers.TarantoolContainerOperations;
1918
import org.testcontainers.containers.VshardClusterContainer;
2019
import org.testcontainers.containers.output.Slf4jLogConsumer;
2120

@@ -24,11 +23,10 @@
2423
import static io.tarantool.spring.data33.utils.TarantoolTestSupport.writeTestPropertiesYaml;
2524
import io.tarantool.spring.data33.config.properties.TarantoolProperties;
2625

27-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
2826
@Timeout(60)
2927
public abstract class BaseIntegrationTest {
3028

31-
protected static TarantoolContainerOperations<?> clusterContainer;
29+
protected static ClusterContainer clusterContainer;
3230

3331
private static final String dockerRegistry =
3432
System.getenv().getOrDefault("TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX", "");

tarantool-spring-data/tarantool-spring-data-33/src/test/java/io/tarantool/spring/data33/integration/crud/CrudConfigurations.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414
import org.junit.jupiter.api.BeforeAll;
1515
import org.junit.jupiter.api.BeforeEach;
16-
import org.junit.jupiter.api.Disabled;
1716
import org.junit.jupiter.api.Test;
1817
import org.springframework.beans.factory.annotation.Autowired;
1918
import org.springframework.context.annotation.Bean;
@@ -34,7 +33,6 @@
3433
import io.tarantool.spring.data33.integration.BaseIntegrationTest;
3534
import io.tarantool.spring.data33.repository.config.EnableTarantoolRepositories;
3635

37-
@Disabled("Refactor TarantoolCartridgeContainer and VshardClusterContainer")
3836
@TestPropertySource(properties = {DEFAULT_PROPERTY_FILE_LOCATION_CLASSPATH})
3937
abstract class CrudConfigurations extends BaseIntegrationTest {
4038

0 commit comments

Comments
 (0)