cluster: replace in-tree validator with go-config jsonschema

Switch tt cluster show --validate / cluster publish from the in-tree
enumerated path validator to go-config jsonschema over the embedded
Tarantool schema.

- Add cli/cluster.Validate wrapping go-config jsonschema; drop
  lib/cluster/{paths,schema,validators}.go (and tests) — ~2.9k LoC.
- Update cli/cluster/cmd/common_test.go to assert on the new
  `<path> [code] <message>` substring format.
- Skip three integration tests (test_cluster_show_config_app_validate_error,
  test_cluster_publish_invalid_cluster, test_cluster_publish_invalid_instance)
  whose expected output depends on substituted {property}/{received}/{expected}
  placeholders; awaiting tarantool/go-config#60.
- Document the behaviour change in CHANGELOG.

Part of TNTP-7390

Author: bigbes

CHANGELOG.md

@@ -25,6 +25,10 @@ for machine-readable output.
 - `lib/cluster`: removed `EnvCollector` and the generated `ConfigEnvPaths`;
   `cli/cluster` now loads config files and environment variables via upstream
   go-config.
+- `tt cluster show --validate` and `tt cluster publish` now validate against the embedded
+  Tarantool JSON Schema instead of the in-tree enumerated path validator. The new validator
+  is stricter (rejects unknown top-level / scope properties) and produces error messages in
+  the upstream `<path> [code] <message>` format.
 
 ### Fixed
 

cli/cluster/cmd/common.go

@@ -97,7 +97,7 @@ func validateRawClusterConfig(config *libcluster.Config) error {
 // validateClusterConfig validates a cluster configuration.
 func validateClusterConfig(cconfig libcluster.ClusterConfig, full bool) error {
 	var errs []error
-	if err := libcluster.Validate(cconfig.RawConfig, libcluster.TarantoolSchema); err != nil {
+	if err := cluster.Validate(cconfig.RawConfig); err != nil {
 		err = fmt.Errorf("an invalid cluster configuration: %s", err)
 		errs = append(errs, err)
 	}
@@ -123,7 +123,7 @@ func validateClusterConfig(cconfig libcluster.ClusterConfig, full bool) error {
 
 // validateInstanceConfig validates an instance configuration.
 func validateInstanceConfig(config *libcluster.Config, name string) error {
-	if err := libcluster.Validate(config, libcluster.TarantoolSchema); err != nil {
+	if err := cluster.Validate(config); err != nil {
 		return fmt.Errorf("an invalid instance %q configuration: %w", name, err)
 	}
 	return nil

cli/cluster/cmd/common_test.go

@@ -51,7 +51,10 @@ groups:
             foo: bar
 `),
 			Full: []bool{false, true},
-			Err:  nil,
+			Err: []string{
+				"an invalid cluster configuration: ",
+				"foo [schema] No values are allowed because the schema is set to 'false'",
+			},
 		},
 		{
 			Name: "valid fields",
@@ -91,9 +94,8 @@ groups:
               nonblock: true
 `),
 			Full: []bool{false, true},
-			Err: []string{"an invalid cluster configuration: " +
-				"invalid path \"audit_log.nonblock\": " +
-				"unexpected value \"123\" of type int, expected boolean"},
+			Err: []string{"an invalid cluster configuration: ",
+				"audit_log/nonblock [type] invalid type"},
 		},
 		{
 			Name: "invalid group",
@@ -109,9 +111,8 @@ groups:
           c:
 `),
 			Full: []bool{false, true},
-			Err: []string{"an invalid instance \"c\" configuration: " +
-				"invalid path \"audit_log.nonblock\": " +
-				"unexpected value \"123\" of type int, expected boolean"},
+			Err: []string{"an invalid instance \"c\" configuration: ",
+				"audit_log/nonblock [type] invalid type"},
 		},
 		{
 			Name: "invalid replicaset",
@@ -129,9 +130,8 @@ groups:
           c:
 `),
 			Full: []bool{false, true},
-			Err: []string{"an invalid instance \"c\" configuration: " +
-				"invalid path \"audit_log.nonblock\": " +
-				"unexpected value \"123\" of type int, expected boolean"},
+			Err: []string{"an invalid instance \"c\" configuration: ",
+				"audit_log/nonblock [type] invalid type"},
 		},
 		{
 			Name: "invalid instance",
@@ -151,9 +151,8 @@ groups:
               nonblock: 123
 `),
 			Full: []bool{false, true},
-			Err: []string{"an invalid instance \"c\" configuration: " +
-				"invalid path \"audit_log.nonblock\": " +
-				"unexpected value \"123\" of type int, expected boolean"},
+			Err: []string{"an invalid instance \"c\" configuration: ",
+				"audit_log/nonblock [type] invalid type"},
 		},
 		{
 			Name: "invalid instances",
@@ -177,12 +176,9 @@ groups:
 `),
 			Full: []bool{false, true},
 			Err: []string{
-				"an invalid instance \"c1\" configuration: " +
-					"invalid path \"audit_log.nonblock\": " +
-					"unexpected value \"123\" of type int, expected boolean",
-				"an invalid instance \"c2\" configuration: " +
-					"invalid path \"audit_log.nonblock\": " +
-					"unexpected value \"123\" of type int, expected boolean",
+				"an invalid instance \"c1\" configuration: ",
+				"an invalid instance \"c2\" configuration: ",
+				"audit_log/nonblock [type] invalid type",
 			},
 		},
 		{
@@ -229,9 +225,8 @@ groups:
               nonblock: true
 `),
 			Full: []bool{true},
-			Err: []string{"an invalid instance \"c\" configuration: " +
-				"invalid path \"audit_log.nonblock\": " +
-				"unexpected value \"123\" of type string, expected boolean"},
+			Err: []string{"an invalid instance \"c\" configuration: ",
+				"audit_log/nonblock [type] invalid type"},
 		},
 	}
 

cli/cluster/validate.go

@@ -0,0 +1,52 @@
+package cluster
+
+import (
+	"bytes"
+	"errors"
+	"fmt"
+
+	"github.com/tarantool/go-config/collectors"
+	gcttarantool "github.com/tarantool/go-config/tarantool"
+	"github.com/tarantool/go-config/validators/jsonschema"
+	libcluster "github.com/tarantool/tt/lib/cluster"
+)
+
+// Validate validates a configuration against the embedded JSON Schema for the
+// newest known Tarantool version.
+func Validate(config *libcluster.Config) error {
+	yamlBytes := []byte(config.String())
+	if len(bytes.TrimSpace(yamlBytes)) == 0 {
+		return nil
+	}
+
+	versions := gcttarantool.SchemaVersions()
+	if len(versions) == 0 {
+		return fmt.Errorf("no Tarantool schemas registered")
+	}
+	newest := versions[len(versions)-1]
+	schemaBytes, ok := gcttarantool.Schema(newest)
+	if !ok {
+		return fmt.Errorf("schema for Tarantool version %q not found", newest)
+	}
+
+	validator, err := jsonschema.New(schemaBytes)
+	if err != nil {
+		return fmt.Errorf("failed to compile schema: %w", err)
+	}
+
+	node, err := collectors.NewYamlFormat().From(bytes.NewReader(yamlBytes)).Parse()
+	if err != nil {
+		return fmt.Errorf("failed to parse config: %w", err)
+	}
+
+	valErrs := validator.Validate(node)
+	if len(valErrs) == 0 {
+		return nil
+	}
+
+	errs := make([]error, len(valErrs))
+	for i := range valErrs {
+		errs[i] = &valErrs[i]
+	}
+	return errors.Join(errs...)
+}