cli: switch cluster config to goconfig.MutableConfig#1297
Merged
Conversation
bigbes
force-pushed
the
bigbes/tntp-7390-cli-goconfig
branch
from
9b841b1 to
d47b34a
Compare
sssciel
approved these changes
May 18, 2026
bigbes
force-pushed
the
bigbes/tntp-7390-cli-goconfig
branch
from
d47b34a to
a339449
Compare
bigbes
force-pushed
the
bigbes/tntp-7390-cli-goconfig
branch
5 times, most recently
from
22dd1c9 to
d077e2e
Compare
Migrate the loader, publish/show flows, and replicaset patch flows in cli/cluster and cli/replicaset to operate on goconfig.Config / MutableConfig + KeyPath instead of the in-tree libcluster.ClusterConfig hierarchy. The loader (cli/cluster.GetClusterConfig) is rewritten as a two-phase merge: env (TT_*_DEFAULT ignored) and file first, then a fill-only merge of remote storage (etcd/TCS, first reachable wins), then a fill-only merge of TT_*_DEFAULT. Storage I/O is plumbed through the gsconnect/go-storage abstraction (NewStorageConnection + NewRemoteStorage) and integrity is wired via GetStorageVerifiers / WithFileReadFunc / WithIntegrity. The new helpers in cli/cluster (scope, storage, BuildGoConfigFromBytes, BuildMutableFromBytes, FindInstance, FindGroupByReplicaset, InstanceConfig, Instances, LibclusterToConfig) replace the old typed wrappers and Instantiate path. Part of TNTP-7390
bigbes
force-pushed
the
bigbes/tntp-7390-cli-goconfig
branch
from
d077e2e to
19c05ee
Compare
sssciel
approved these changes
May 25, 2026
patapenka-alexey
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the loader, publish/show flows, and replicaset patch flows in cli/cluster and cli/replicaset to operate on goconfig.Config / MutableConfig + KeyPath instead of the in-tree libcluster.ClusterConfig hierarchy. The loader (cli/cluster.GetClusterConfig) is rewritten as a two-phase merge: env (TT_DEFAULT ignored) and file first, then a fill-only merge of remote storage (etcd/TCS, first reachable wins), then a fill-only merge of TT_DEFAULT. Storage I/O is plumbed through the gsconnect/go-storage abstraction (NewStorageConnection + NewRemoteStorage) and integrity is wired via GetStorageVerifiers / WithFileReadFunc / WithIntegrity. The new helpers in cli/cluster (scope, storage, BuildGoConfigFromBytes, BuildMutableFromBytes, FindInstance, FindGroupByReplicaset, InstanceConfig, Instances, LibclusterToConfig) replace the old typed wrappers and Instantiate path.
Part of TNTP-7390