Skip to content

Upgrade dev dependencies in package.json#55

Merged
tarmolov merged 8 commits into
tarmolov:masterfrom
rjmunro:upgrade-deps
May 3, 2018
Merged

Upgrade dev dependencies in package.json#55
tarmolov merged 8 commits into
tarmolov:masterfrom
rjmunro:upgrade-deps

Conversation

@rjmunro

@rjmunro rjmunro commented May 2, 2018

Copy link
Copy Markdown
Contributor

But stick with a 2.x.x version of JSCS as upgrading to 3.x.x broke things.

@rjmunro rjmunro changed the title Upgrade dependencies in package.json Upgrade dev dependencies in package.json May 2, 2018
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.01%) to 92.929% when pulling 5f45ed7 on rjmunro:upgrade-deps into aaf26a1 on tarmolov:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.01%) to 92.929% when pulling 5f45ed7 on rjmunro:upgrade-deps into aaf26a1 on tarmolov:master.

@coveralls

coveralls commented May 2, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.9%) to 97.895% when pulling a09af18 on rjmunro:upgrade-deps into e83af69 on tarmolov:master.

@tarmolov

tarmolov commented May 2, 2018

Copy link
Copy Markdown
Owner

I think it's better to replace jsint + jscs with eslint.
https://github.com/ymaps/codestyle/tree/master/packages/eslint-config-loris — here is the right base config for it.

Would you like to make this replacement in this pr?

@rjmunro

rjmunro commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

@tarmolov I can look into that, yes. What do you think of dropping support for node 0.x? So we would only support node 4 and above? It means we can drop some older code and use e.g. execSync and have to worry about accessSync versus existsSync.

@tarmolov

tarmolov commented May 3, 2018

Copy link
Copy Markdown
Owner

I think 4 can be dropped as well according to https://github.com/nodejs/Release#release-schedule.
After this changes it's better to up git-hooks major version because we break backward compatibility.

@rjmunro

rjmunro commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

I've upgraded to node v5 and removed some code only necessary on older versions. I've had a go at moving to eslint, but I've decided that should be a separate PR (#59) as I'm not sure how to fix the errors it is throwing.

It would be great if this could be merged, then I can rebase #57 and #58 and therefore fix #48. This would mean that my project would start validating even when it is a submodule, which will save me a lot of frustration.

@tarmolov
tarmolov merged commit 5951059 into tarmolov:master May 3, 2018
@rjmunro
rjmunro deleted the upgrade-deps branch May 4, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants