You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+13Lines changed: 13 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -185,6 +185,19 @@ Maintainers reserve the right to decline review or close pull requests for any r
185
185
186
186
- For changes in server, please make sure to refer to the [server development documentation](./tools/server/README-dev.md)
187
187
188
+
# New GGML Backends
189
+
190
+
- Add yourself to [CODEOWNERS](CODEOWNERS) to claim ownership of the backend.
191
+
- Follow the [coding guidelines](#coding-guidelines).
192
+
- In your PR description, include a section showcasing the performance improvements. Use `llama-bench` for this.
193
+
- If possible, provide the necessary CI workflow (and hardware) to test your changes (see [ci/README.md](https://github.com/ggml-org/llama.cpp/tree/master/ci)).
194
+
- If you need to add third-party dependencies, extra files, or extra headers:
195
+
- Download/link the required files via CMake as a build step.
196
+
- Otherwise, ensure that the files are licensed under MIT; same as llama.cpp. And keep these extras as minimal as possible.
197
+
- Keep your initial implementation minimal to the `GGML_OP_MUL_MAT` operator with support only for `GGML_TYPE_F32`.
198
+
- Once your backend is approved and upstream, you can create more PRs to further support the backend.
199
+
- This is to reduce the amount of time and effort required for review, and ensure you understand the basics of the GGML backend system.
0 commit comments