ci: attempt self-hosted run#5
Open
taronaeo wants to merge 3 commits into
Open
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the CI workflow to run the x64 CPU low- and high-performance jobs on a self-hosted x64 runner instead of GitHub’s ubuntu-22.04 hosted runners. Flow diagram for CI job execution on self-hosted x64 runnerflowchart TD
TRIGGER[Push or PR event] --> DISPATCH[Dispatch build.yml workflow]
DISPATCH --> LOW[Job ggml-ci-x64-cpu-low-perf]
DISPATCH --> HIGH[Job ggml-ci-x64-cpu-high-perf]
LOW --> SELECT_LOW[Select runner with labels self-hosted and X64]
HIGH --> SELECT_HIGH[Select runner with labels self-hosted and X64]
SELECT_LOW --> RUN_LOW[Execute low-perf build and tests]
SELECT_HIGH --> RUN_HIGH[Execute high-perf build and tests]
RUN_LOW --> RESULTS_LOW[Upload artifacts and report status]
RUN_HIGH --> RESULTS_HIGH[Upload artifacts and report status]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
runs-onvalue should use a list when specifying multiple labels (e.g.runs-on: [self-hosted, X64]) rather than a comma-separated string, otherwise GitHub Actions may not match the runner correctly. - Consider using a more specific runner label than just
X64(e.g.self-hosted-x64-ci) to avoid unintentionally matching other generic self-hosted runners and to make maintenance easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `runs-on` value should use a list when specifying multiple labels (e.g. `runs-on: [self-hosted, X64]`) rather than a comma-separated string, otherwise GitHub Actions may not match the runner correctly.
- Consider using a more specific runner label than just `X64` (e.g. `self-hosted-x64-ci`) to avoid unintentionally matching other generic self-hosted runners and to make maintenance easier.
## Individual Comments
### Comment 1
<location path=".github/workflows/build.yml" line_range="1064" />
<code_context>
# TODO: run lighter CI on PRs and the full CI only on master (if needed)
ggml-ci-x64-cpu-low-perf:
- runs-on: ubuntu-22.04
+ runs-on: self-hosted, X64
steps:
</code_context>
<issue_to_address>
**issue (bug_risk):** The `runs-on` value should likely be a list of labels rather than a single comma-separated string.
GitHub Actions only supports a single label (e.g. `runs-on: self-hosted`) or an array (e.g. `runs-on: [self-hosted, X64]`). The current scalar `runs-on: self-hosted, X64` won’t match any runner and the job will never run. Please change this to an array, e.g. `runs-on: [self-hosted, X64]`, matching your actual runner labels.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Additional information
Requirements
Summary by Sourcery
Update CI workflow to run x64 CPU low- and high-performance jobs on a self-hosted X64 runner instead of the standard Ubuntu 22.04 GitHub-hosted runner.
CI: