Skip to content

ci: attempt self-hosted run#5

Open
taronaeo wants to merge 3 commits into
masterfrom
feat/cpu-ci
Open

ci: attempt self-hosted run#5
taronaeo wants to merge 3 commits into
masterfrom
feat/cpu-ci

Conversation

@taronaeo

@taronaeo taronaeo commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Overview

Additional information

Requirements

Summary by Sourcery

Update CI workflow to run x64 CPU low- and high-performance jobs on a self-hosted X64 runner instead of the standard Ubuntu 22.04 GitHub-hosted runner.

CI:

  • Switch ggml x64 low-performance CPU CI job to a self-hosted X64 runner.
  • Switch ggml x64 high-performance CPU CI job to a self-hosted X64 runner.

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
@sourcery-ai

sourcery-ai Bot commented Mar 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the CI workflow to run the x64 CPU low- and high-performance jobs on a self-hosted x64 runner instead of GitHub’s ubuntu-22.04 hosted runners.

Flow diagram for CI job execution on self-hosted x64 runner

flowchart TD
  TRIGGER[Push or PR event] --> DISPATCH[Dispatch build.yml workflow]
  DISPATCH --> LOW[Job ggml-ci-x64-cpu-low-perf]
  DISPATCH --> HIGH[Job ggml-ci-x64-cpu-high-perf]

  LOW --> SELECT_LOW[Select runner with labels self-hosted and X64]
  HIGH --> SELECT_HIGH[Select runner with labels self-hosted and X64]

  SELECT_LOW --> RUN_LOW[Execute low-perf build and tests]
  SELECT_HIGH --> RUN_HIGH[Execute high-perf build and tests]

  RUN_LOW --> RESULTS_LOW[Upload artifacts and report status]
  RUN_HIGH --> RESULTS_HIGH[Upload artifacts and report status]
Loading

File-Level Changes

Change Details Files
Update CI workflow to use a self-hosted x64 runner for key CPU test jobs.
  • Change the ggml-ci-x64-cpu-low-perf job to target a self-hosted, X64 runner label.
  • Change the ggml-ci-x64-cpu-high-perf job to target a self-hosted, X64 runner label.
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The runs-on value should use a list when specifying multiple labels (e.g. runs-on: [self-hosted, X64]) rather than a comma-separated string, otherwise GitHub Actions may not match the runner correctly.
  • Consider using a more specific runner label than just X64 (e.g. self-hosted-x64-ci) to avoid unintentionally matching other generic self-hosted runners and to make maintenance easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `runs-on` value should use a list when specifying multiple labels (e.g. `runs-on: [self-hosted, X64]`) rather than a comma-separated string, otherwise GitHub Actions may not match the runner correctly.
- Consider using a more specific runner label than just `X64` (e.g. `self-hosted-x64-ci`) to avoid unintentionally matching other generic self-hosted runners and to make maintenance easier.

## Individual Comments

### Comment 1
<location path=".github/workflows/build.yml" line_range="1064" />
<code_context>
 # TODO: run lighter CI on PRs and the full CI only on master (if needed)
   ggml-ci-x64-cpu-low-perf:
-    runs-on: ubuntu-22.04
+    runs-on: self-hosted, X64

     steps:
</code_context>
<issue_to_address>
**issue (bug_risk):** The `runs-on` value should likely be a list of labels rather than a single comma-separated string.

GitHub Actions only supports a single label (e.g. `runs-on: self-hosted`) or an array (e.g. `runs-on: [self-hosted, X64]`). The current scalar `runs-on: self-hosted, X64` won’t match any runner and the job will never run. Please change this to an array, e.g. `runs-on: [self-hosted, X64]`, matching your actual runner labels.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .github/workflows/build.yml Outdated
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant