Skip to content

Commit 792e265

Browse files
committed
fix(publish): don’t force npmjs registry via publishConfig
Remove publishConfig.registry so publishing can target other registries (e.g. GitHub Packages) without npm redirecting back to npmjs. Also narrow .npmrc scope override to @taskade/eslint-plugin only.
1 parent 74913f4 commit 792e265

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@taskade/temporal-parser": patch
3+
---
4+
5+
build(ci): Allow publishing to GitHub Packages by removing the hard-coded npmjs registry from `publishConfig`.

.github/workflows/publish.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ jobs:
1010
name: Release
1111
runs-on: ubuntu-latest
1212
permissions:
13+
id-token: write
1314
contents: write
1415
packages: write
1516
pull-requests: write
@@ -49,9 +50,6 @@ jobs:
4950
publish: npm run release
5051
title: 'chore: version packages'
5152
commit: 'chore: version packages'
52-
env:
53-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
54-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
5553

5654
# Only publish to GitHub Packages if npm publish succeeded
5755
- name: Setup Node.js for GitHub Packages

.npmrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
# Override global @taskade scope to use public npm registry for this project
2-
@taskade:registry=https://registry.npmjs.org/
1+
# Use public npm registry for @taskade/eslint-plugin only
2+
@taskade/eslint-plugin:registry=https://registry.npmjs.org/

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
"url": "git+https://github.com/taskade/temporal-parser.git"
2929
},
3030
"publishConfig": {
31-
"access": "public",
32-
"registry": "https://registry.npmjs.org"
31+
"access": "public"
3332
},
3433
"keywords": [
3534
"temporal",

0 commit comments

Comments
 (0)