fix: use constant-time comparison for auth token (CWE-208)#576
Open
spidershield-contrib wants to merge 1 commit intotaskgenius:masterfrom
Open
fix: use constant-time comparison for auth token (CWE-208)#576spidershield-contrib wants to merge 1 commit intotaskgenius:masterfrom
spidershield-contrib wants to merge 1 commit intotaskgenius:masterfrom
Conversation
Replace direct === comparison with crypto.timingSafeEqual via SHA-256 digest to prevent timing-based token extraction attacks. - No behavioral change for valid authentication flows - Uses stdlib only (crypto) — no new dependencies Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #575 — replaces timing-vulnerable
===comparison with constant-timetimingSafeEqualvia SHA-256 digest.Changes
safeEqual()helper usingcrypto.createHash+crypto.timingSafeEqual===invalidateRequest()with constant-time comparisonCWE Reference
crypto) — no new dependenciesFound by SpiderShield security scanner