Skip to content

fix: remove startup/shutdown calls incompatible with Starlette 1.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megalaren wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: remove startup/shutdown calls incompatible with Starlette 1.0 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1497542
fix: remove startup/shutdown calls incompatible with Starlette 1.0
Apr 1, 2026
d085148
Bump fastapi to >=0.133.0
Apr 1, 2026
ce96e59
Constrain fastapi version to <1
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ classifiers = [
"Development Status :: 3 - Alpha",
]
keywords = ["taskiq", "tasks", "distributed", "async", "fastapi"]
dependencies = ["taskiq>=0.8.0", "fastapi>=0.93.0"]
dependencies = ["taskiq>=0.8.0", "fastapi>=0.133.0,<1"]

[dependency-groups]
dev = [
Expand Down
2 changes: 0 additions & 2 deletions taskiq_fastapi/initializator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ async def startup(state: TaskiqState) -> None:
raise ValueError(f"'{app_or_path}' is not a FastAPI application.")

state.fastapi_app = app
await app.router.startup()
state.lf_ctx = app.router.lifespan_context(app)
asgi_state = await state.lf_ctx.__aenter__()
populate_dependency_context(broker, app, asgi_state)
Expand All @@ -62,7 +61,6 @@ def shutdown_event_generator(
async def shutdown(state: TaskiqState) -> None:
if not broker.is_worker_process:
return
await state.fastapi_app.router.shutdown()
await state.lf_ctx.__aexit__(None, None, None)

return shutdown
Expand Down