Merge pull request #10 from samsonasik/test-display

Test display

Author: MGatner

composer.json

@@ -21,11 +21,13 @@
 	"repositories": [
 		{
 			"type": "vcs",
-			"url": "https://github.com/codeigniter4/CodeIgniter4"
+			"url": "https://github.com/codeigniter4/CodeIgniter4",
+			"no-api": true
 		},
 		{
 			"type": "vcs",
-			"url": "https://github.com/lonnieezell/myth-auth"
+			"url": "https://github.com/lonnieezell/myth-auth",
+			"no-api": true
 		},
 		{
 			"type": "composer",

tests/feature/DisplayTest.php

@@ -19,10 +19,81 @@ public function testNoFiles()
 	public function testDefaultDisplaysCards()
 	{
 		$file = fake(FileFaker::class);
-		
+
 		$result = $this->get('files');
 
 		$result->assertStatus(200);
 		$result->assertSee($file->filename);
 	}
+
+	public function provideSort()
+	{
+		yield ['filename', 'filename'];
+		yield ['localname', 'localname'];
+		yield ['clientname', 'clientname'];
+		yield ['type', 'type'];
+		yield ['size', 'size'];
+		yield ['thumbnail', 'thumbnail'];
+		yield ['invalidsort', 'filename'];
+	}
+
+	/**
+	 * @dataProvider provideSort
+	 */
+	public function testSorts(string $sort, string $configSort)
+	{
+		$_REQUEST['sort'] = $sort;
+
+		$file = fake(FileFaker::class);
+		$result = $this->get('files');
+
+		$result->assertStatus(200);
+		$this->assertEquals($configSort, service('settings')->filesSort);
+	}
+
+	public function provideOrder()
+	{
+		yield ['asc', 'asc'];
+		yield ['desc', 'desc'];
+		yield ['invalid', 'asc'];
+	}
+
+	/**
+	 * @dataProvider provideOrder
+	 */
+	public function testOrders(string $order, string $configOrder)
+	{
+		$_REQUEST['order'] = $order;
+
+		$file = fake(FileFaker::class);
+		$result = $this->get('files');
+
+		$result->assertStatus(200);
+		$this->assertEquals($configOrder, service('settings')->filesOrder);
+	}
+
+	public function provideSearch()
+	{
+		yield ['Heathcote'];
+	}
+
+	/**
+	 * @dataProvider provideSearch
+	 */
+	public function testSearches(string $keyword)
+	{
+		$_REQUEST['search'] = $keyword;
+
+		$file = fake(FileFaker::class);
+		$result = $this->get('files');
+
+		$result->assertStatus(200);
+		$content = $result->response->getBody();
+
+		if (strpos($content, $keyword) !== false) {
+			$result->assertSee($keyword);
+		} else {
+			$result->assertSee('You have no files!');
+		}
+	}
 }

tests/unit/ControllerTest.php

@@ -24,17 +24,6 @@ protected function setUp(): void
 		$this->controller = null;
 	}
 
-	public function testThrowsWithoutAuthFunction()
-	{
-		// Since we cannot un-define a function we use the config override cheat
-		$this->config->failNoAuth = true; // @phpstan-ignore-line
-
-		$this->expectException(FilesException::class);
-		$this->expectExceptionMessage(lang('Files.noAuth'));
-
-		$controller = new Files($this->config);
-	}
-
 	public function testThrowsWithInvalidStoragePath()
 	{
 		$this->config->storagePath = HOMEPATH . 'README.md';
@@ -57,17 +46,6 @@ public function testCreatesMissingStoragePath()
 		$this->assertDirectoryIsWritable($this->config->storagePath);
 	}
 
-	public function testUsesExternalModelIfFound()
-	{
-		require_once SUPPORTPATH . 'app/Models/FileModel.php';
-
-		$this->controller(Files::class);
-
-		$result = $this->getPrivateProperty($this->controller, 'model');
-
-		$this->assertInstanceOf('App\Models\FileModel', $result);
-	}
-
 	//--------------------------------------------------------------------
 
 	public function testGetSortUsesInput()