Skip to content

Improve formatnum parserfn#424

Draft
kristian-clausal wants to merge 1 commit into
mainfrom
formatnum
Draft

Improve formatnum parserfn#424
kristian-clausal wants to merge 1 commit into
mainfrom
formatnum

Conversation

@kristian-clausal

@kristian-clausal kristian-clausal commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #423

Improvements to formatnum:

  1. Do not format bad input, only allow digits, period and commas
  2. Commas are only allowed with the R "reverse" flag that converts from "formatted" to "raw". Basically it removes commas at its simplest.
  3. Turns out the commas can go anywhere. I wrote a ton of logic that checked that the commas were "correct" in the input, but turns out it doesn't matter at all...

I'll look into localization later in this draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatnum issue

1 participant