Use workspace dependency management#15412
Conversation
|
I was just about to ping @jbolda to ask whether covector supports this but CI already answered my question 😂 |
|
I do like this approach though so maybe we can fix covector |
|
Any plan for workspace lint rules? |
Package Changes Through 207a102There are 1 changes which include tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
@Tunglies Not yet, you can open an issue on which lint rules do you want to enable and we can discuss there
@FabianLars I couldn't remember what was the problem back then, it seems to work at least in this run https://github.com/tauri-apps/tauri/actions/runs/28021124759/job/82937404412?pr=15412 |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
I like this a lot, but we probably need to fix the feature flags first since some of them actually depends on the default features
|
This was the error https://github.com/tauri-apps/tauri/actions/runs/26026811997/job/76506308250 - i think it still does not work but there are no subcrate (eg tauri-utils instead of tauri) changefiles anymore so it doesn't check. |
Can you explain? Just seen I missed a spot or two that are using their own paths instead of the workspace deps. |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
pretty much every example basically
| serde_json = "1" | ||
| serde = { version = "1", features = ["derive"] } | ||
| tauri = { path = "../../../../crates/tauri", features = [] } | ||
| tauri = { workspace = true } |
There was a problem hiding this comment.
This needs wry, as well as the other bench crates
|
|
||
| [dependencies] | ||
| tauri = { path = "../../../../crates/tauri" } | ||
| tauri = { workspace = true } |
There was a problem hiding this comment.
This should also require wry
| "codegen", | ||
| "isolation", | ||
| ] } | ||
| tauri-build = { workspace = true, features = ["codegen", "isolation"] } |
|
Following up here as we had conversations on other mediums. Working through this support in |
5 participants
We can simplify dependency management a bit by centralizing the workspace-internal dependencies.