Skip to content

refactor: reduced some clones#15413

Merged
Legend-Master merged 4 commits into
tauri-apps:devfrom
Legend-Master:reduce-clones
Jul 5, 2026
Merged

refactor: reduced some clones#15413
Legend-Master merged 4 commits into
tauri-apps:devfrom
Legend-Master:reduce-clones

Conversation

@Legend-Master

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through b292729

There are 2 changes which include tauri-bundler with patch, tauri-runtime-wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.9.2 2.9.3
tauri-runtime-wry 2.11.2 2.12.0
tauri 2.11.2 2.11.3
@tauri-apps/cli 2.11.2 2.11.3
tauri-cli 2.11.2 2.11.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@sftse

sftse commented May 18, 2026

Copy link
Copy Markdown
Contributor

I think this is the right direction to go in more in general. Lifetimes seem like a nuisance but help discover hierarchically well structured designs that are much less likely to lead to deadlocks and memory leaks.

I have similar changes I think we should make heading towards v3.

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Yeah, that's what I thought as well, these changes were made so I could see where are these things used and the flow more clearly

@Legend-Master Legend-Master added this to the 2.12 milestone May 19, 2026
@Legend-Master Legend-Master marked this pull request as ready for review May 19, 2026 01:58
@Legend-Master Legend-Master requested a review from a team as a code owner May 19, 2026 01:58
@Tunglies

Copy link
Copy Markdown
Contributor

From Arc<WindowsStore> to &WindowsStore might changed behavior.

pub struct WindowsStore(pub RefCell<BTreeMap<WindowId, WindowWrapper>>)

Now we cannot move ownership cross-thread, forcing processing in single thread stack.

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Now we cannot move ownership cross-thread, forcing processing in single thread stack.

Yeah, that's the whole point, they should not be crossing to another thread

@sftse

sftse commented May 25, 2026

Copy link
Copy Markdown
Contributor

Now we cannot move ownership cross-thread, forcing processing in single thread stack.

To be precise, this PR still allows multithreaded access. #14805 will remove it, so Arc becomes dead weight.

@Tunglies

Copy link
Copy Markdown
Contributor

Thanks for brings more context, now I see it.

@Legend-Master Legend-Master merged commit 7fd6035 into tauri-apps:dev Jul 5, 2026
19 checks passed
@Legend-Master Legend-Master deleted the reduce-clones branch July 5, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants