Skip to content

fix: drop tray icon on main thread#15558

Draft
Legend-Master wants to merge 1 commit into
tauri-apps:devfrom
Legend-Master:drop-tray-icon-on-main-thread
Draft

fix: drop tray icon on main thread#15558
Legend-Master wants to merge 1 commit into
tauri-apps:devfrom
Legend-Master:drop-tray-icon-on-main-thread

Conversation

@Legend-Master

Copy link
Copy Markdown
Contributor

Fix #12534

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through 2b47f5e

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Legend-Master force-pushed the drop-tray-icon-on-main-thread branch from 2267cee to d0cbc90 Compare June 18, 2026 04:23
@Legend-Master

Copy link
Copy Markdown
Contributor Author

Actually, this might not really fix #12534, since in most cases, you call cleanup_before_exit and then process::exit straight away, if it's called off main thread, the exit will come before the main thread message gets processed.

This will also cause a small regression on Windows in the updater to clean up the tray icons (on Windows, even though the deconstructor will fail on DestroyWindow, the Shell_NotifyIconW(NIM_DELETE, ...) call still works off main thread).

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Don't know if it's a terrible idea to send and wait cleanup_before_exit to run on main thread...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] App::cleanup_before_exit() can crash if not run on main thread

1 participant