Skip to content

Commit dad4cbf

Browse files
committed
review
1 parent 5c483f2 commit dad4cbf

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

Mathlib/FieldTheory/Galois/IsGaloisGroup.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ theorem card_eq_finrank' : Nat.card G = Module.finrank A B := by
123123
let := FractionRing.liftAlgebra A (FractionRing B)
124124
let := IsFractionRing.mulSemiringAction G B (FractionRing B)
125125
rw [IsGaloisGroup.card_eq_finrank G (FractionRing A) (FractionRing B),
126-
IsFractionRing.finrank_eq A B (FractionRing A) (FractionRing B)]
126+
IsFractionRing.finrank_eq A (FractionRing A) B (FractionRing B)]
127127

128128
@[simp]
129129
theorem map_mulEquivAlgEquiv_fixingSubgroup [IsGaloisGroup G K L] (F : IntermediateField K L) :

Mathlib/LinearAlgebra/Dimension/Localization.lean

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,16 @@ theorem IsFractionRing.finrank_left_eq (A : Type*) [CommRing A] [Algebra S A] [A
138138
exact ⟨finsetIntegerMultiple S⁰ s, card_finsetIntegerMultiple S⁰ s,
139139
linearIndepOn_finsetIntegerMultiple S⁰ hs⟩
140140

141-
variable (R) in
142-
theorem IsFractionRing.finrank_eq (R' S' : Type*) [CommRing R'] [CommRing S'] [Module R' S']
143-
[Algebra R R'] [Algebra S S'] [Algebra R S'] [IsScalarTower R R' S'] [IsScalarTower R S S']
144-
[IsFractionRing R R'] [IsFractionRing S S'] : Module.finrank R' S' = Module.finrank R S :=
145-
(finrank_right_eq R R' S').trans (finrank_left_eq R S S').symm
141+
/-- If `K` is the fraction ring of `A` and `L` is the fraction ring of `B`, then the finrank
142+
`finrank K L` of the fraction rings equals the finrank `A B` of the base rings.
143+
144+
See `IsFractionRing.finrank_left_eq` and `IsFractionRing.finrank_right_eq` for one-sided versions.
145+
See `Algebra.IsAlgebraic.rank_of_isFractionRing` for a rank version with additional assumptions. -/
146+
protected theorem IsFractionRing.finrank_eq (A K B L : Type*)
147+
[CommRing A] [CommRing K] [CommRing B] [CommRing L] [Algebra A B] [Module K L]
148+
[Algebra A K] [Algebra B L] [Algebra A L] [IsScalarTower A K L] [IsScalarTower A B L]
149+
[IsFractionRing A K] [IsFractionRing B L] : Module.finrank K L = Module.finrank A B :=
150+
(finrank_right_eq A K L).trans (finrank_left_eq A B L).symm
146151

147152
variable (R M) in
148153
theorem exists_set_linearIndependent_of_isDomain [IsDomain R] :

0 commit comments

Comments
 (0)