Skip to content

Add label existence check to umxModify #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add label existence check to umxModify #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion R/build_run_modify.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,31 @@ umxModify <- function(lastFit, update = NULL, regex = FALSE, free = FALSE, value
# handle labels as input
if (!regex) {
theLabels = update
# TODO: check the labels are present
# check the labels are present
# if not suggest reversal for with items
modelLabels = umxGetParameters(newModel)
if(!all(theLabels %in% modelLabels)){
# Some labels missing
missingLabels = theLabels[!theLabels %in% modelLabels]
msg = paste0("Some labels not found in model: ", paste(omxQuotes(missingLabels), collapse=", "))

# check for "with" items that are reversed
# e.g. looking for "a_with_b", but model has "b_with_a"
for(thisLabel in missingLabels){
if(grepl("_with_", thisLabel)){
# flip it
splitLabel = strsplit(thisLabel, "_with_")[[1]]
if(length(splitLabel) == 2){
flipLabel = paste0(splitLabel[2], "_with_", splitLabel[1])
if(flipLabel %in% modelLabels){
msg = paste0(msg, "\nFound ", omxQuotes(flipLabel), " in model: maybe you meant that instead of ", omxQuotes(thisLabel), "?")
}
}
}
}
stop(msg)
}

if(is.null(newlabels)){
newModel = omxSetParameters(newModel, labels = theLabels, free = free, values = value, name = name)
}else{
Expand Down
Loading