revert: remove Windows-specific changes deferred to PR-1182

Remove Windows executor compatibility changes (log_destination quoting,
unix_socket_directories platform guard, os.killpg AttributeError catch)
and the Windows-only event_loop_policy fixture from conftest.py.
These belong in the separate Windows compatibility PR dbfixtures#1182.

Made-with: Cursor

Author: tboy1337

pytest_postgresql/executor.py

@@ -50,9 +50,9 @@ class PostgreSQLExecutor(TCPExecutor):
 
     BASE_PROC_START_COMMAND = (
         '{executable} start -D "{datadir}" '
-        "-o \"-F -p {port} -c log_destination=stderr "
+        "-o \"-F -p {port} -c log_destination='stderr' "
         "-c logging_collector=off "
-        "{unix_socket_opt}{postgres_options}\" "
+        "-c unix_socket_directories='{unixsocketdir}' {postgres_options}\" "
         '-l "{logfile}" {startparams}'
     )
 
@@ -108,17 +108,11 @@ def __init__(
         self.logfile = logfile
         self.startparams = startparams
         self.postgres_options = postgres_options
-        # On Windows, Unix sockets are not supported; omit the parameter entirely.
-        unix_socket_opt = (
-            f"-c unix_socket_directories={self.unixsocketdir} "
-            if platform.system() != "Windows"
-            else ""
-        )
         command = self.BASE_PROC_START_COMMAND.format(
             executable=self.executable,
             datadir=self.datadir,
             port=port,
-            unix_socket_opt=unix_socket_opt,
+            unixsocketdir=self.unixsocketdir,
             logfile=self.logfile,
             startparams=self.startparams,
             postgres_options=self.postgres_options,
@@ -236,10 +230,6 @@ def stop(self: T, sig: Optional[int] = None, exp_sig: Optional[int] = None) -> T
         except ProcessFinishedWithError:
             # Finished, leftovers ought to be cleaned afterwards anyway
             pass
-        except AttributeError:
-            # os.killpg is not available on Windows; the pg_ctl stop above
-            # already terminated the process, so this is safe to ignore.
-            pass
         return self
 
     def __del__(self) -> None:

tests/conftest.py

@@ -1,26 +1,12 @@
 """Tests main conftest file."""
 
-import asyncio
 import os
-import sys
-import warnings
 from pathlib import Path
 
-import pytest
 from pytest_postgresql import factories
 from pytest_postgresql.plugin import *  # noqa: F403,F401
 
 pytest_plugins = ["pytester"]
-
-
-@pytest.fixture(scope="session")
-def event_loop_policy():  # type: ignore[override]
-    """Use SelectorEventLoop on Windows; psycopg3 async requires it."""
-    with warnings.catch_warnings():
-        warnings.simplefilter("ignore", DeprecationWarning)
-        if sys.platform == "win32":
-            return asyncio.WindowsSelectorEventLoopPolicy()
-        return asyncio.DefaultEventLoopPolicy()
 POSTGRESQL_VERSION = os.environ.get("POSTGRES", "13")