Honor executor timeout in Windows start() path

subprocess.run() on the Windows synchronous start path had no timeout,
so a stuck pg_ctl could block indefinitely.  Pass self._timeout (the
configured mirakuru timeout in seconds) to subprocess.run(..., timeout=).
Catch subprocess.TimeoutExpired — subprocess.run already kills the
process before re-raising, so no extra cleanup is needed — and translate
it to mirakuru.exceptions.TimeoutExpired so callers see the same
exception type produced by the non-Windows path.

Also imports TimeoutExpired from mirakuru.exceptions alongside the
existing ProcessFinishedWithError import.

Made-with: Cursor

Author: tboy1337

pytest_postgresql/executor.py

@@ -30,7 +30,7 @@
 from typing import Any, Optional, TypeVar
 
 from mirakuru import TCPExecutor
-from mirakuru.exceptions import ProcessFinishedWithError
+from mirakuru.exceptions import ProcessFinishedWithError, TimeoutExpired
 from packaging.version import parse
 
 from pytest_postgresql.exceptions import ExecutableMissingException, PostgreSQLUnsupported
@@ -199,7 +199,12 @@ def start(self: T) -> T:
                 self.logfile,
                 *shlex.split(self.startparams),
             ]
-            result = subprocess.run(args, check=False, env=self.envvars)
+            try:
+                result = subprocess.run(args, check=False, env=self.envvars, timeout=self._timeout)
+            except subprocess.TimeoutExpired as exc:
+                # subprocess.run already killed the stuck pg_ctl process before
+                # re-raising, so no additional cleanup is required here.
+                raise TimeoutExpired(self, self._timeout) from exc
             if result.returncode != 0:
                 raise ProcessFinishedWithError(self, result.returncode)
             return self