Fix output leakage, cross-platform test coverage, and Windows start env/posix

Bug fixes
- executor.py running(): add capture_output=True to subprocess.run so
  pg_ctl status output no longer leaks to the terminal on every call;
  previously the change from getstatusoutput() dropped the implicit
  capture.

- test_windows_compatibility.py: remove the module-level pytestmark
  that skipped every test on non-Windows.  All tests in the file use
  patch() to mock platform.system() and subprocess calls, so none of
  them require a real Windows host; the blanket skip was silently hiding
  the entire template and process-management test suite from Linux/macOS
  CI runs.  The unused sys import is removed along with the mark.

Inline comment fixes
- oldest-postgres.yml: narrow the 'install libpq' step condition to
  also require runner.os == 'Linux' so 'sudo apt install' is not
  attempted on non-Linux runners when the matrix entry contains PyPy.

- executor.py Windows start() branch: build merged_env from
  os.environ.copy() updated with self.envvars so system-level PATH and
  other vital variables are inherited rather than replaced by the
  locale-only dict.

- executor.py Windows start() branch: pass posix=False to
  shlex.split(self.startparams) so Windows backslashes in startparams
  are treated as literals rather than POSIX escape characters.

Nitpick
- newsfragments/1182.feature.rst: rewrite as a concise user-facing
  summary without internal symbol names.

Made-with: Cursor

Author: tboy1337

.github/workflows/oldest-postgres.yml

@@ -52,7 +52,7 @@ jobs:
         run: |
           sudo locale-gen de_DE.UTF-8
       - name: install libpq
-        if: ${{ contains(matrix.python-version, 'pypy') }}
+        if: ${{ contains(matrix.python-version, 'pypy') && runner.os == 'Linux' }}
         run: sudo apt install libpq5
       - name: Install oldest supported versions
         uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4

newsfragments/1182.feature.rst

@@ -1 +1 @@
-Add Windows compatibility for ``PostgreSQLExecutor`` with platform-specific command templates (``UNIX_PROC_START_COMMAND`` / ``WINDOWS_PROC_START_COMMAND``) and a dedicated ``_windows_terminate_process`` method for graceful process termination on Windows.
+Add Windows support for ``PostgreSQLExecutor``, including platform-specific start/stop handling.

pytest_postgresql/executor.py

@@ -197,10 +197,12 @@ def start(self: T) -> T:
                 pg_options,
                 "-l",
                 self.logfile,
-                *shlex.split(self.startparams),
+                *shlex.split(self.startparams, posix=False),
             ]
+            merged_env = os.environ.copy()
+            merged_env.update(self.envvars)
             try:
-                result = subprocess.run(args, check=False, env=self.envvars, timeout=self._timeout)
+                result = subprocess.run(args, check=False, env=merged_env, timeout=self._timeout)
             except subprocess.TimeoutExpired as exc:
                 # subprocess.run already killed the stuck pg_ctl process before
                 # re-raising, so no additional cleanup is required here.
@@ -282,6 +284,7 @@ def running(self) -> bool:
         result = subprocess.run(
             [self.executable, "status", "-D", self.datadir],
             check=False,
+            capture_output=True,
         )
         return result.returncode == 0
 

tests/test_windows_compatibility.py

@@ -2,18 +2,12 @@
 
 import os
 import subprocess
-import sys
 from unittest.mock import MagicMock, patch
 
 import pytest
 
 from pytest_postgresql.executor import PostgreSQLExecutor
 
-pytestmark = pytest.mark.skipif(
-    sys.platform != "win32",
-    reason="Windows-only tests",
-)
-
 
 class TestCommandTemplates:
     """Test platform-specific command templates."""