Skip to content

Security: No CSRF protection with session-based authentication #3010

@Fengsh0923

Description

@Fengsh0923

Problem

Backend uses session-based auth (Passport session strategy) but has no CSRF token mechanism. Only Helmet is configured as security middleware.

Impact

Malicious pages can submit requests on behalf of authenticated users — creating shares, modifying data, changing settings.

Suggested Fix

  1. Add CSRF token middleware (csurf or double-submit cookie)
  2. Or use SameSite=Strict cookies + custom headers for mutations
  3. Add Origin header validation as defense-in-depth

Found during source code review. v1.10.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions