Skip to content

fix(core): allow null/undefined values for required fields with defaults #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −0
Open

fix(core): allow null/undefined values for required fields with defaults #2856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/models/field/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,20 @@ export abstract class FieldCore implements IFieldVo {

/**
* Wrapper to enforce notNull when calling validateCellValue.
* If the field has a default value, null/undefined inputs are allowed
* since the default will be applied later.
*/
validateCellValueWithNotNull(value: unknown): ZodSafeParseResult<unknown> | undefined {
if (this.isComputed) {
return this.validateCellValue(value);
}
if (this.notNull && (value === null || value === undefined)) {
// Check if field has a default value - if so, allow null/undefined
// since the default will be applied later
const options = this.options as { defaultValue?: unknown } | undefined;
if (options?.defaultValue !== undefined) {
return this.validateCellValue(value);
}
return {
success: false,
error: new ZodError([
Expand Down