[sync] T5395 fix: route BYODB attachment lookup to meta DB#3475
[sync] T5395 fix: route BYODB attachment lookup to meta DB#3475tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@b9dbeb1 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3435028c03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -14,7 +14,8 @@ export interface IRecordChangedValueDecoratorService { | |||
|
|
|||
| decorateChangedFieldsByRecord( | |||
| table: Table, | |||
| changedFieldsByRecord?: ReadonlyMap<string, ReadonlyMap<string, unknown>> | |||
| changedFieldsByRecord?: ReadonlyMap<string, ReadonlyMap<string, unknown>>, | |||
| previousFieldsByRecord?: ReadonlyMap<string, Record<string, unknown>> | |||
There was a problem hiding this comment.
When a v2 bulk record update renames an attachment, this new previousFieldsByRecord argument is required so AttachmentValueDecoratorService can compare old/new names and invalidate attachment:preview:<token>. In production, however, apps/nestjs-backend/src/features/v2/v2-container.service.ts registers V2RecordChangedValueDecoratorService, whose decorateChangedFieldsByRecord method still only accepts (table, changedFieldsByRecord) and calls the core decorator without forwarding this third argument, so the old values passed from RecordBulkUpdateService are silently dropped and preview URLs can keep stale filenames after bulk attachment renames.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
238 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@b9dbeb1
This PR was automatically created by the sync workflow.