[sync] T5585 Allow deleting error-state table nodes#3476
Conversation
Synced from teableio/teable-ee@2e8e738 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef7e0f4f4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -542,7 +579,7 @@ export const TableOperation = (props: IBaseNodeMoreProps) => { | |||
| return null; | |||
| } | |||
|
|
|||
| if (!Object.values(menuPermission).some(Boolean)) { | |||
| if (!nodeId && !Object.values(menuPermission).some(Boolean)) { | |||
There was a problem hiding this comment.
In the error-state case this new nodeId fallback is trying to cover, the table is absent from useTables(), so the earlier if (!table) return null exits before this branch can render anything; even if that return is bypassed, the delete item is still gated on table?.permission?.['table|delete']. As a result, failed/provisioning table nodes still have no More menu/delete action and users remain unable to remove them from the sidebar.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
239 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@2e8e738
This PR was automatically created by the sync workflow.