[sync] T5586 fix aggregation mixed-case field references#3478
[sync] T5586 fix aggregation mixed-case field references#3478tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@ac25291 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4fd95bdb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'Content-Type': 'application/json', | ||
| ...options?.headers, | ||
| }, | ||
| body: JSON.stringify(clearRo), |
There was a problem hiding this comment.
This serializes the non-stream IClearByIdRo shape directly. The server stream handlers validate selectionIdsRoSchema, whose inverse-selection fields are allRecords/excludedRecordIds, while IClearByIdRo uses excludeRecordIds; for select-all-except or query-scoped selections the request will be rejected or lose exclusions. Convert to the stream selection shape before sending, and apply the same conversion to the paste/delete stream helpers.
Useful? React with 👍 / 👎.
| await streamSSE<IDeleteSelectionStreamEvent>( | ||
| url, | ||
| { | ||
| method: 'POST', |
There was a problem hiding this comment.
This helper sends POST, but the Nest endpoint added for the same /delete-by-id-stream path is registered with @Patch, and the existing stream helper also uses PATCH. Any consumer using this newly exported helper or the generated route metadata will call the wrong HTTP method and fail before receiving the SSE stream.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
241 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@ac25291
This PR was automatically created by the sync workflow.