[sync] fix byodb read-only target preflight#3482
Conversation
Synced from teableio/teable-ee@e66c778 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
1 similar comment
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e260b1ca7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // degrade to a full-table scan. SET LOCAL statement_timeout makes Postgres cancel the | ||
| // statement and release the pooled connection, instead of the client abandoning the | ||
| // request while the query keeps running and starves the connection pool. | ||
| await prisma.$executeRawUnsafe(`SET LOCAL statement_timeout = ${searchTimeout}`); |
There was a problem hiding this comment.
When SEARCH_TIMEOUT is left at its new 15000ms default, this SET LOCAL statement_timeout is inside withDataPrismaTransaction(...) without transaction options, so the data Prisma service still applies its 5000ms default interactive-transaction timeout before PostgreSQL's statement timeout can fire. In deployments that rely on the new search timeout, searches will still abort around 5s (and may miss the intended DB-side cancellation); pass a transaction timeout with headroom over searchTimeout for this path.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
245 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@e66c778
This PR was automatically created by the sync workflow.