[sync] fix: stop BYODB restore on first error#3491
Conversation
Synced from teableio/teable-ee@e078889 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2951295611
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (this.cls.get('useV2')) { | ||
| return this.pasteByIdWithV2(tableId, pasteRo); | ||
| } | ||
|
|
||
| return this.selectionService.pasteById(tableId, pasteRo, { windowId }); |
There was a problem hiding this comment.
When a request is authenticated via X-Tea-Share-View, the permission guard allows /selection mutation endpoints and relies on the controller to call ShareViewScopeService to enforce the shared view's filter/projection. The existing range-based paste/clear/delete handlers do that, but this new by-id path (and the matching clear/delete/by-id stream paths below) goes straight to the mutation services, so a share-view editor who knows record or field IDs can paste into, clear, or delete records/hidden fields outside the shared view. Please apply equivalent share-view scope checks to the explicit IDs before mutating.
Useful? React with 👍 / 👎.
2 participants
🔄 Automated sync from EE repository.
254 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@e078889
This PR was automatically created by the sync workflow.