fix: resolve test script issues and improve error handling

- Fix cluster-lifecycle.sh test by removing invalid --preserve-existing flag from destroy command
  * infra destroy doesn't support --preserve-existing (only infra apply does)
  * Update documentation text to clarify actual safety mechanism
  * Default behavior already only destroys resources defined in YAML configurations

- Fix database-operations.sh unbound variable errors and improve authentication
  * Resolve $1 unbound variable error by using ${1:-all} pattern
  * Add user existence validation before attempting username/password authentication
  * Improve error messages and user feedback for missing manual credentials
  * Enhanced robustness when manual database users aren't configured

Both scripts now run successfully with source .env from project root directory.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: tip-dteller

scripts/test/cluster-lifecycle.sh

@@ -309,7 +309,7 @@ test_yaml_cluster_lifecycle() {
     local config_file="$TEST_REPORTS_DIR/yaml-cluster-config.yaml"
 
     print_info "Testing YAML cluster lifecycle with cluster: $cluster_name"
-    print_success "✓ SAFE MODE: Using --preserve-existing to protect existing clusters"
+    print_success "✓ SAFE MODE: Only managing resources defined in YAML configurations"
 
     # Get project name for proper YAML configuration
     local project_name
@@ -470,11 +470,10 @@ EOF
     sleep 3
 
     print_info "Destroying cluster and users..."
-    print_info "Using --preserve-existing to protect any existing clusters"
+    print_info "Only destroying resources defined in YAML configuration (existing clusters protected)"
 
     if "$PROJECT_ROOT/matlas" infra destroy -f "$config_file" \
         --project-id "$ATLAS_PROJECT_ID" \
-        --preserve-existing \
         --auto-approve; then
 
         print_success "Infrastructure destroy initiated"
@@ -1263,7 +1262,7 @@ run_cluster_lifecycle_tests() {
 
     print_header "MongoDB Atlas Cluster Lifecycle Tests"
     print_warning "⚠️  WARNING: These tests create real Atlas clusters and may incur costs!"
-    print_success "✓ SAFE MODE: Tests now use --preserve-existing to protect existing clusters"
+    print_success "✓ SAFE MODE: Tests only manage resources defined in configurations"
     print_info "Tests only manage resources they create - existing resources are preserved"
     echo
 
@@ -1337,7 +1336,7 @@ show_usage() {
     echo
     echo "Commands:"
     echo "  cli              Run CLI-based cluster lifecycle tests only"
-    echo "  yaml             Run YAML-based cluster lifecycle tests (now SAFE with --preserve-existing)"
+    echo "  yaml             Run YAML-based cluster lifecycle tests (SAFE - only manages defined resources)"
     echo "  yaml-existing    Run YAML test with existing clusters (safe individual resources)"
     echo "  yaml-multi       Run YAML multi-cluster test (clean project scenario)"
     echo "  yaml-partial     Run YAML partial removal test (add 2, remove 1)"
@@ -1360,14 +1359,14 @@ show_usage() {
     echo "  ATLAS_ORG_ID        Atlas organization ID"
     echo
     echo "Examples:"
-    echo "  $0                     # Run basic safe tests (CLI + YAML with --preserve-existing)"
+    echo "  $0                     # Run basic safe tests (CLI + YAML - only manages defined resources)"
     echo "  $0 comprehensive       # Run all test scenarios (recommended)"
     echo "  $0 yaml-existing       # Test YAML with existing clusters (safe)"
     echo "  $0 yaml-multi          # Test YAML multi-cluster management"
     echo "  $0 yaml-partial        # Test YAML partial removal"
     echo "  $0 cli                 # Test CLI approach only"
     echo ""
-    echo "SAFETY: All YAML tests now use --preserve-existing to protect existing resources"
+    echo "SAFETY: All tests only manage resources they define - existing resources are protected"
 }
 
 # Main execution

scripts/test/database-operations.sh

@@ -148,12 +148,22 @@ test_all_authentication_methods() {
 
     # Test 2: --username/--password authentication (if available)
     if [[ -n "$TEST_DATABASE_USER" && -n "$TEST_DATABASE_PASSWORD" ]]; then
+        print_info "Found manual database credentials - testing username/password authentication"
         print_subheader "Test 2: Database creation with --username/--password"
         local test_db2="${test_db_base}-userpass"
 
         print_info "Testing database creation with user credentials: $TEST_DATABASE_USER"
 
-        if "$PROJECT_ROOT/matlas" database create "$test_db2" \
+        # First verify the database user exists and has permissions
+        print_info "Verifying manual database user exists and has permissions..."
+        if ! "$PROJECT_ROOT/matlas" atlas users list --project-id "$ATLAS_PROJECT_ID" 2>/dev/null | grep -q "$TEST_DATABASE_USER"; then
+            print_warning "Manual database user '$TEST_DATABASE_USER' not found in Atlas project"
+            print_info "Skipping username/password authentication test"
+            print_info "To test this method, create a database user in Atlas with readWriteAnyDatabase permissions"
+        else
+            print_success "Manual database user found in Atlas project"
+            
+            if "$PROJECT_ROOT/matlas" database create "$test_db2" \
         --cluster "$TEST_CLUSTER_NAME" \
         --project-id "$ATLAS_PROJECT_ID" \
             --collection "$test_collection" \
@@ -175,9 +185,10 @@ test_all_authentication_methods() {
             else
                 print_warning "Database not immediately visible (propagation delay expected)"
             fi
-        else
-            print_error "Failed to create database with --username/--password"
-            ((auth_failures++))
+            else
+                print_error "Failed to create database with --username/--password"
+                ((auth_failures++))
+            fi
         fi
     else
         print_info "Skipping --username/--password test (no manual credentials provided)"
@@ -964,14 +975,14 @@ show_usage() {
 main() {
     case "${1:-all}" in
         "auth"|"failures"|"databases"|"collections"|"indexes"|"yaml"|"workflow"|"comprehensive"|"all")
-            run_database_operations_tests "$1"
+            run_database_operations_tests "${1:-all}"
             ;;
         "-h"|"--help"|"help")
             show_usage
             exit 0
             ;;
         *)
-            echo "Unknown command: $1"
+            echo "Unknown command: ${1:-}"
             echo
             show_usage
             exit 1