fix(cli): resolve errcheck violations and standardize config command flags

BREAKING CHANGE: config template generate and export commands now use --file instead of --output flag

## Error Handling Fixes
- Fix unchecked MarkHidden() error returns in database command (cmd/database/database.go)
- Fix unchecked MongoDB client.Disconnect() error returns in roles command (cmd/database/roles/roles.go)
- Fix unchecked MongoDB client.Disconnect() error returns in users command (cmd/database/users/users.go)
- Add proper error handling with panic for flag configuration failures
- Add warning messages for MongoDB connection cleanup failures

## CLI Improvements
- Standardize config command flags: rename --output/-o to --file for consistency
- Update template generate command examples and help text
- Update export command examples and help text
- Improve flag naming consistency across config subcommands

## Testing Infrastructure
- Add comprehensive config command test suite (scripts/test/config-test.sh)
- Test template generation, validation, experimental commands, error handling
- Add config tests to main test runner (scripts/test.sh)
- Include config tests in comprehensive test suite

## Documentation
- Update config.md to reflect --file flag usage
- Update command help text and examples

## Project Tracking
- Document all bug fixes and improvements in tracking/bugfixes.md
- Update test script tracking documentation

Resolves GoLinting errcheck violations and improves CLI consistency.

Refs: #errcheck-fixes #config-standardization

Author: tip-dteller

cmd/config/config.go

@@ -117,17 +117,17 @@ Resource Configuration Templates:
   matlas config template generate basic
 
   # Generate Atlas configuration template to file
-  matlas config template generate atlas --output atlas-config.yaml
+  matlas config template generate atlas --file atlas-config.yaml
 
   # Generate in JSON format
-  matlas config template generate complete --format json --output config.json`,
+  matlas config template generate complete --format json --file config.json`,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			templateType = args[0]
 			return runGenerateTemplate(cmd, templateType, outputFile, format)
 		},
 	}
 
-	cmd.Flags().StringVarP(&outputFile, "output", "o", "", "Output file path (default: stdout)")
+	cmd.Flags().StringVar(&outputFile, "file", "", "Output file path (default: stdout)")
 	cmd.Flags().StringVarP(&format, "format", "f", "yaml", "Output format (yaml, json)")
 
 	return cmd
@@ -210,10 +210,10 @@ This command can export configurations to:
 - YAML configuration files
 - Shell export statements`,
 		Example: `  # Export to environment file
-  matlas config export --format env --output config.env
+  matlas config export --format env --file config.env
 
   # Export to JSON
-  matlas config export --format json --output config.json
+  matlas config export --format json --file config.json
 
   # Export including sensitive values
   matlas config export --include-secrets --format yaml
@@ -225,7 +225,7 @@ This command can export configurations to:
 		},
 	}
 
-	cmd.Flags().StringVarP(&outputFile, "output", "o", "", "Output file path (default: stdout)")
+	cmd.Flags().StringVar(&outputFile, "file", "", "Output file path (default: stdout)")
 	cmd.Flags().StringVarP(&format, "format", "f", "yaml", "Export format (yaml, json, env, shell)")
 	cmd.Flags().BoolVar(&includeSecrets, "include-secrets", false, "Include sensitive values in export")
 

cmd/database/database.go

@@ -92,7 +92,10 @@ available databases, including their size, whether they're empty, and collection
 
 	// Hidden flag for advanced users to specify custom roles for temporary users
 	cmd.Flags().String("temp-user-roles", "", "Advanced: Multiple custom roles for temporary user (format: 'role1@db1,role2@db2'). Default: readWriteAnyDatabase@admin")
-	cmd.Flags().MarkHidden("temp-user-roles")
+	if err := cmd.Flags().MarkHidden("temp-user-roles"); err != nil {
+		// This should not fail as the flag was just added
+		panic(fmt.Errorf("failed to mark temp-user-roles flag as hidden: %w", err))
+	}
 
 	// At least one connection method is required
 	cmd.MarkFlagsOneRequired("connection-string", "cluster")
@@ -164,7 +167,10 @@ Authentication options:
 
 	// Hidden flag for advanced users to specify custom roles for temporary users
 	cmd.Flags().String("temp-user-roles", "", "Advanced: Multiple custom roles for temporary user (format: 'role1@db1,role2@db2'). Default: readWrite@<database>")
-	cmd.Flags().MarkHidden("temp-user-roles")
+	if err := cmd.Flags().MarkHidden("temp-user-roles"); err != nil {
+		// This should not fail as the flag was just added
+		panic(fmt.Errorf("failed to mark temp-user-roles flag as hidden: %w", err))
+	}
 
 	// At least one connection method is required
 	cmd.MarkFlagsOneRequired("connection-string", "cluster")
@@ -228,7 +234,10 @@ Use with caution in production environments.`,
 
 	// Hidden flag for advanced users to specify custom roles for temporary users
 	cmd.Flags().String("temp-user-roles", "", "Advanced: Multiple custom roles for temporary user (format: 'role1@db1,role2@db2'). Default: readWriteAnyDatabase@admin")
-	cmd.Flags().MarkHidden("temp-user-roles")
+	if err := cmd.Flags().MarkHidden("temp-user-roles"); err != nil {
+		// This should not fail as the flag was just added
+		panic(fmt.Errorf("failed to mark temp-user-roles flag as hidden: %w", err))
+	}
 
 	// At least one connection method is required
 	cmd.MarkFlagsOneRequired("connection-string", "cluster")

cmd/database/roles/roles.go

@@ -242,7 +242,11 @@ func runListRoles(cmd *cobra.Command, connectionString, clusterName, projectID,
 		progress.StopSpinnerWithError("Failed to connect to MongoDB")
 		return fmt.Errorf("failed to connect to MongoDB: %w", err)
 	}
-	defer client.Disconnect(ctx)
+	defer func() {
+		if err := client.Disconnect(ctx); err != nil {
+			fmt.Printf("Warning: Failed to disconnect from MongoDB: %v\n", err)
+		}
+	}()
 
 	// Get the database
 	db := client.Database(databaseName)
@@ -336,7 +340,11 @@ func runCreateRole(cmd *cobra.Command, connectionString, clusterName, projectID,
 		progress.StopSpinnerWithError("Failed to connect to MongoDB")
 		return fmt.Errorf("failed to connect to MongoDB: %w", err)
 	}
-	defer client.Disconnect(ctx)
+	defer func() {
+		if err := client.Disconnect(ctx); err != nil {
+			fmt.Printf("Warning: Failed to disconnect from MongoDB: %v\n", err)
+		}
+	}()
 
 	// Get the database
 	db := client.Database(databaseName)
@@ -444,7 +452,11 @@ func runDeleteRole(cmd *cobra.Command, connectionString, clusterName, projectID,
 		progress.StopSpinnerWithError("Failed to connect to MongoDB")
 		return fmt.Errorf("failed to connect to MongoDB: %w", err)
 	}
-	defer client.Disconnect(ctx)
+	defer func() {
+		if err := client.Disconnect(ctx); err != nil {
+			fmt.Printf("Warning: Failed to disconnect from MongoDB: %v\n", err)
+		}
+	}()
 
 	// Get the database
 	db := client.Database(databaseName)
@@ -484,7 +496,11 @@ func runGetRole(cmd *cobra.Command, connectionString, clusterName, projectID, da
 		progress.StopSpinnerWithError("Failed to connect to MongoDB")
 		return fmt.Errorf("failed to connect to MongoDB: %w", err)
 	}
-	defer client.Disconnect(ctx)
+	defer func() {
+		if err := client.Disconnect(ctx); err != nil {
+			fmt.Printf("Warning: Failed to disconnect from MongoDB: %v\n", err)
+		}
+	}()
 
 	// Get the database
 	db := client.Database(databaseName)

cmd/database/users/users.go

@@ -312,7 +312,11 @@ func runListDatabaseUsers(cmd *cobra.Command, connectionString, clusterName, pro
 		progress.StopSpinnerWithError("Failed to connect to MongoDB")
 		return fmt.Errorf("failed to connect to MongoDB: %w", err)
 	}
-	defer client.Disconnect(ctx)
+	defer func() {
+		if err := client.Disconnect(ctx); err != nil {
+			fmt.Printf("Warning: Failed to disconnect from MongoDB: %v\n", err)
+		}
+	}()
 
 	// Get the admin database for user operations
 	// Note: All user management operations should be performed on admin database

docs/config.md

@@ -25,7 +25,7 @@ List and generate config templates.
 
 ```bash
 matlas config template list
-matlas config template generate <basic|atlas|database|apply|complete> [-o file] [-f yaml|json]
+matlas config template generate <basic|atlas|database|apply|complete> [--file output-file] [--format yaml|json]
 ```
 
 Notes:

scripts/test.sh

@@ -47,6 +47,7 @@ COMMANDS:
     discovery   Run discovery lifecycle tests (comprehensive discovery feature testing)
                 Use --cluster-lifecycle flag to include cluster creation/deletion tests (costs money!)
     applydoc    Run ApplyDocument format tests (comprehensive coverage)
+    config      Run configuration command tests (validate, template generation, experimental commands)
     all         Run all tests (unit + integration + e2e)
     comprehensive Run all tests including cluster and applydoc tests
     clean       Clean test cache and artifacts
@@ -67,6 +68,8 @@ EXAMPLES:
     $0 discovery            # Run discovery lifecycle tests
     $0 discovery --cluster-lifecycle  # Run discovery tests with cluster creation (costs money!)
     $0 applydoc             # Run ApplyDocument format tests
+    $0 config               # Run configuration command tests
+    $0 config --verbose     # Run config tests with verbose output
     $0 e2e                  # Run e2e tests (users/network only)
     $0 e2e --include-clusters  # Run e2e tests with real clusters
     $0 users                # Run live users lifecycle tests
@@ -237,17 +240,29 @@ main() {
                 return 1
             fi
             ;;
+        config)
+            print_info "Running configuration command tests..."
+            print_info "Testing: validate, template generation, experimental commands, error handling"
+            if "$SCRIPT_DIR/test/config-test.sh" "${args[@]}"; then
+                print_success "Configuration command tests passed"
+            else
+                print_error "Configuration command tests failed"
+                return 1
+            fi
+            ;;
         comprehensive)
             local failed=0
             print_info "Running comprehensive test suite (all test types)..."
             run_test_type "unit" "${args[@]}" || ((failed++))
             run_test_type "integration" "${args[@]}" || ((failed++))
             run_test_type "e2e" "${args[@]}" || ((failed++))
 
-            print_warning "⚠️  Including ApplyDocument, discovery, and cluster tests - CLUSTER TESTS CREATE/DELETE REAL CLUSTERS!"
+            print_warning "⚠️  Including ApplyDocument, discovery, config, and cluster tests - CLUSTER TESTS CREATE/DELETE REAL CLUSTERS!"
             print_success "✓ SAFE MODE: Cluster tests use --preserve-existing to protect existing clusters"
             print_info "ℹ️  Database and discovery tests require existing cluster but do NOT create/delete clusters"
+            print_info "ℹ️  Config tests are safe and do not require external resources"
             "$SCRIPT_DIR/test/applydocument-test.sh" "${args[@]}" || ((failed++))
+            "$SCRIPT_DIR/test/config-test.sh" "${args[@]}" || ((failed++))
             "$SCRIPT_DIR/test/discovery-lifecycle.sh" "${args[@]}" || ((failed++))
             "$SCRIPT_DIR/test/database-operations.sh" "${args[@]}" || ((failed++))
             "$SCRIPT_DIR/test/cluster-lifecycle.sh" "${args[@]}" || ((failed++))