Conversation
Decode GOOGLE_SERVICES_JSON before saving to file.
Closed
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR performs repository-wide cleanup including modifications to the Android CI workflow (base64 decoding for google-services.json and removal of build/test steps), extensive import reordering across database and design-system modules, trailing comma formatting adjustments, removal of unused imports, and a function rename of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed build and test steps from CI workflow
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 42-43: The CI currently only runs the "Check Ktlint" step that
executes "./gradlew ktlintCheck" so compile failures and test regressions are
missed; add at least one build task (e.g., a step named "Build" that runs
"./gradlew build" or "./gradlew assemble") and one test task (e.g., a step named
"Run Tests" that runs "./gradlew test" or "./gradlew
connectedAndroidTest"/appropriate test task) to the workflow so the pipeline
validates compilation and test outcomes in addition to ktlint; ensure the new
steps are placed after any dependency/setup steps and fail the job on non-zero
exit codes.
Comment on lines
42
to
43
| - name: Check Ktlint | ||
| run: ./gradlew ktlintCheck |
There was a problem hiding this comment.
CI no longer validates build/test correctness.
With only ktlintCheck running, this workflow won’t catch compile failures or broken tests before merge. Please add at least one build and one test step back as a quality gate.
Suggested CI gate restoration
- name: Check Ktlint
run: ./gradlew ktlintCheck
+
+ - name: Build with Gradle
+ run: ./gradlew assemble
+
+ - name: Run unit tests
+ run: ./gradlew test🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/ci.yml around lines 42 - 43, The CI currently only runs
the "Check Ktlint" step that executes "./gradlew ktlintCheck" so compile
failures and test regressions are missed; add at least one build task (e.g., a
step named "Build" that runs "./gradlew build" or "./gradlew assemble") and one
test task (e.g., a step named "Run Tests" that runs "./gradlew test" or
"./gradlew connectedAndroidTest"/appropriate test task) to the workflow so the
pipeline validates compilation and test outcomes in addition to ktlint; ensure
the new steps are placed after any dependency/setup steps and fail the job on
non-zero exit codes.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/keyboardAsState.kt (1)
10-14: Rename tokeyboardAsStateto follow Compose naming conventions.In Jetpack Compose,
@Composablefunctions that return a value (rather thanUnit) should use lowerCamelCase, similar to standard Kotlin functions and APIs likerememberUpdatedState,remember, andderivedStateOf. Since this function returnsState<Boolean>, usekeyboardAsState()instead ofKeyboardAsState().🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/keyboardAsState.kt` around lines 10 - 14, Rename the composable function KeyboardAsState to keyboardAsState (lowerCamelCase) and update its declaration and all call sites to the new name; ensure the `@Composable` annotation, return type State<Boolean>, and internals (isImeVisible, WindowInsets.ime.getBottom(LocalDensity.current), rememberUpdatedState) remain unchanged so behavior is preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/keyboardAsState.kt`:
- Around line 10-14: Rename the composable function KeyboardAsState to
keyboardAsState (lowerCamelCase) and update its declaration and all call sites
to the new name; ensure the `@Composable` annotation, return type State<Boolean>,
and internals (isImeVisible, WindowInsets.ime.getBottom(LocalDensity.current),
rememberUpdatedState) remain unchanged so behavior is preserved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3a5463cb-e652-44e0-a95d-b3fe2b9b59ad
📒 Files selected for processing (2)
core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/button/Button.ktcore/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/keyboardAsState.kt
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/KeyboardAsState.kt (1)
11-11: UsekeyboardAsState()and provide a deprecated alias for migration.
KeyboardAsState()returnsState<Boolean>, which means it must follow standard Kotlin function naming conventions in lowerCamelCase per Compose guidelines. The current PascalCase name is non-idiomatic and introduces a source-breaking change. Rename tokeyboardAsState()and keep the old name as a deprecated forwarder for backward compatibility.Proposed migration-safe diff
`@Composable` -fun KeyboardAsState(): State<Boolean> { +fun keyboardAsState(): State<Boolean> { val isImeVisible = WindowInsets.ime.getBottom(LocalDensity.current) > 0 return rememberUpdatedState(newValue = isImeVisible) } + +@Deprecated( + message = "Use keyboardAsState()", + replaceWith = ReplaceWith("keyboardAsState()") +) +@Composable +fun KeyboardAsState(): State<Boolean> = keyboardAsState()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/KeyboardAsState.kt` at line 11, Rename the top-level function KeyboardAsState() to follow Kotlin/Compose naming conventions: change its declaration to keyboardAsState(): State<Boolean> and update all internal references to call the new name; then add a deprecated forwarding alias named KeyboardAsState() that is annotated `@Deprecated` with a ReplaceWith("keyboardAsState()") and simply returns keyboardAsState() to preserve binary/source compatibility. Ensure the new function signature and return type remain State<Boolean> and that the deprecated wrapper delegates to it without changing behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/KeyboardAsState.kt`:
- Line 11: Rename the top-level function KeyboardAsState() to follow
Kotlin/Compose naming conventions: change its declaration to keyboardAsState():
State<Boolean> and update all internal references to call the new name; then add
a deprecated forwarding alias named KeyboardAsState() that is annotated
`@Deprecated` with a ReplaceWith("keyboardAsState()") and simply returns
keyboardAsState() to preserve binary/source compatibility. Ensure the new
function signature and return type remain State<Boolean> and that the deprecated
wrapper delegates to it without changing behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 23780853-931a-432e-ba7d-c0cfbcfc26b5
📒 Files selected for processing (2)
core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/ComposeExt.ktcore/design-system/src/main/java/team/aliens/dms/android/core/designsystem/util/KeyboardAsState.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode GOOGLE_SERVICES_JSON before saving to file.
개요
작업사항
추가 로 할 말
Summary by CodeRabbit
Release Notes