Skip to content

πŸ”€ :: (#830) ci 적용 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uson1004 merged 7 commits into from
Mar 16, 2026
Merged

πŸ”€ :: (#830) ci 적용 #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
581268f
Update google-services.json creation step
uson1004 Mar 15, 2026
c868d9e
Update CI workflow to remove Gradle build and test
uson1004 Mar 15, 2026
287b009
refactor :: λΉŒλ“œ ν”Œλ ˆμ΄λ²„ 곡백 제거
uson1004 Mar 16, 2026
57b7b93
refactor :: μ•ˆ μ“°μ΄λŠ” μš”μ†Œ 제거
uson1004 Mar 16, 2026
6b058e2
refactor :: μœ„μΉ˜ 정리
uson1004 Mar 16, 2026
6ce390e
chore :: ktlintCheck
uson1004 Mar 16, 2026
7199c6c
chore :: ktlintCheck
uson1004 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,8 @@ jobs:

- name: Create google-services.json
run: |
mkdir -p ${{ github.workspace }}/app
echo '${{ secrets.GOOGLE_SERVICES_JSON }}' > ${{ github.workspace }}/app/google-services.json

- name: Build with Gradle
run: ./gradlew assembleDebug --parallel

- name: Run test
run: ./gradlew test
mkdir -p ${{ github.workspace }}/app
echo '${{ secrets.GOOGLE_SERVICES_JSON }}' | base64 --decode > ${{ github.workspace }}/app/google-services.json

- name: Check Ktlint
run: ./gradlew ktlintCheck
Comment on lines 42 to 43
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

CI no longer validates build/test correctness.

With only ktlintCheck running, this workflow won’t catch compile failures or broken tests before merge. Please add at least one build and one test step back as a quality gate.

Suggested CI gate restoration 
       - name: Check Ktlint
         run: ./gradlew ktlintCheck
+
+      - name: Build with Gradle
+        run: ./gradlew assemble
+
+      - name: Run unit tests
+        run: ./gradlew test
πŸ€– Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 42 - 43, The CI currently only runs
the "Check Ktlint" step that executes "./gradlew ktlintCheck" so compile
failures and test regressions are missed; add at least one build task (e.g., a
step named "Build" that runs "./gradlew build" or "./gradlew assemble") and one
test task (e.g., a step named "Run Tests" that runs "./gradlew test" or
"./gradlew connectedAndroidTest"/appropriate test task) to the workflow so the
pipeline validates compilation and test outcomes in addition to ktlint; ensure
the new steps are placed after any dependency/setup steps and fail the job on
non-zero exit codes.

4 changes: 2 additions & 2 deletions ...tabase/src/main/java/team/aliens/dms/android/core/database/converter/DateTypeConverter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ package team.aliens.dms.android.core.database.converter

import androidx.room.ProvidedTypeConverter
import androidx.room.TypeConverter
import team.aliens.dms.android.shared.date.toLocalDate
import team.aliens.dms.android.shared.date.toLocalDateTime
import java.time.LocalDate
import java.time.LocalDateTime
import java.time.ZoneOffset
import team.aliens.dms.android.shared.date.toLocalDate
import team.aliens.dms.android.shared.date.toLocalDateTime
import javax.inject.Inject

@ProvidedTypeConverter
Expand Down
2 changes: 1 addition & 1 deletion core/database/src/main/java/team/aliens/dms/android/core/database/dao/MealDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import androidx.room.Dao
import androidx.room.Insert
import androidx.room.OnConflictStrategy
import androidx.room.Query
import java.time.LocalDate
import team.aliens.dms.android.core.database.entity.MealEntity
import java.time.LocalDate

@Dao
abstract class MealDao {
Expand Down
2 changes: 1 addition & 1 deletion core/database/src/main/java/team/aliens/dms/android/core/database/di/DatabaseModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.android.qualifiers.ApplicationContext
import dagger.hilt.components.SingletonComponent
import java.time.ZoneOffset
import team.aliens.dms.android.core.database.DmsDatabase
import team.aliens.dms.android.core.database.converter.DateTypeConverter
import team.aliens.dms.android.core.database.converter.StringListTypeConverter
import team.aliens.dms.android.core.database.converter.UuidTypeConverter
import team.aliens.dms.android.core.database.dao.MealDao
import team.aliens.dms.android.core.database.dao.NoticeDao
import team.aliens.dms.android.core.database.util.addTypeConverters
import java.time.ZoneOffset
import javax.inject.Singleton

@Module
Expand Down
1 change: 0 additions & 1 deletion core/design-system/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
0 ...s/dms/android/core/designsystem/Colors.kt β†’ ...dms/android/core/designsystem/DmsColor.kt
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/button/Button.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ import team.aliens.dms.android.core.designsystem.bodyM
import team.aliens.dms.android.core.designsystem.indicator.DmsDotsLoadingIndicator
import team.aliens.dms.android.core.designsystem.labelM
import team.aliens.dms.android.core.designsystem.util.DEFAULT_PRESS_DEPTH
import team.aliens.dms.android.core.designsystem.util.KeyboardAsState
import team.aliens.dms.android.core.designsystem.util.MIN_PRESS_DEPTH
import team.aliens.dms.android.core.designsystem.util.clickable
import team.aliens.dms.android.core.designsystem.util.keyboardAsState
import team.aliens.dms.android.core.designsystem.util.modifyIf

data class ButtonState(
Expand Down Expand Up @@ -211,7 +211,7 @@ private fun BasicButton(
content = content,
)*/

val keyboardShow by keyboardAsState()
val keyboardShow by KeyboardAsState()
val isKeyboardHideButton = keyboardShow && keyboardInteractionEnabled
val (shapeByKeyboardShow, pressDepth) = if (isKeyboardHideButton) {
RoundedCornerShape(0.dp) to MIN_PRESS_DEPTH
Expand Down
3 changes: 1 addition & 2 deletions ...gn-system/src/main/java/team/aliens/dms/android/core/designsystem/calendar/DmsCalendar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,11 @@ import team.aliens.dms.android.core.designsystem.bodyM
import team.aliens.dms.android.core.designsystem.button.ButtonColor
import team.aliens.dms.android.core.designsystem.button.ButtonType
import team.aliens.dms.android.core.designsystem.button.DmsButton
import team.aliens.dms.android.core.designsystem.util.clickable
import team.aliens.dms.android.core.designsystem.horizontalPadding
import team.aliens.dms.android.core.designsystem.util.clickable
import team.aliens.dms.android.core.designsystem.verticalPadding
import java.time.LocalDate
import java.time.YearMonth
import kotlin.time.Duration.Companion.days
import kotlin.time.ExperimentalTime

@OptIn(ExperimentalTime::class)
Expand Down
1 change: 0 additions & 1 deletion ...sign-system/src/main/java/team/aliens/dms/android/core/designsystem/dialog/AlertDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.Shape
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.DialogProperties
import team.aliens.dms.android.core.designsystem.DmsTheme
Expand Down
5 changes: 2 additions & 3 deletions ...gn-system/src/main/java/team/aliens/dms/android/core/designsystem/foundation/DmsSymbol.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package team.aliens.dms.android.core.designsystem.foundation
import androidx.compose.foundation.Image
import androidx.compose.foundation.isSystemInDarkTheme
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
Expand All @@ -29,7 +28,7 @@ fun DmsSymbolContent(

Column(
modifier = Modifier
.horizontalPadding(24.dp)
.horizontalPadding(24.dp),
) {
Image(
modifier = modifier,
Expand All @@ -46,7 +45,7 @@ fun DmsSymbolContent(
modifier = Modifier.topPadding(12.dp),
text = description,
style = DmsTheme.typography.bodyM,
color = DmsTheme.colorScheme.inverseSurface
color = DmsTheme.colorScheme.inverseSurface,
)
}
}
0 ...roid/core/designsystem/util/composeExt.kt β†’ ...roid/core/designsystem/util/ComposeExt.kt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...core/designsystem/util/keyboardAsState.kt β†’ ...core/designsystem/util/KeyboardAsState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import androidx.compose.runtime.rememberUpdatedState
import androidx.compose.ui.platform.LocalDensity

@Composable
fun keyboardAsState(): State<Boolean> {
fun KeyboardAsState(): State<Boolean> {
val isImeVisible = WindowInsets.ime.getBottom(LocalDensity.current) > 0
return rememberUpdatedState(newValue = isImeVisible)
}
1 change: 0 additions & 1 deletion core/device/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion core/jwt/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion core/network/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion core/notification/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion core/school/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion core/ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion core/ui/src/main/java/team/aliens/dms/android/core/ui/navigation/ResultStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ object LocalResultStore {
get() = LocalResultStore.current ?: error("No ResultStore has been provided")

infix fun provides(
store: ResultStore
store: ResultStore,
): ProvidedValue<ResultStore?> {
return LocalResultStore.provides(store)
}
Expand Down
1 change: 0 additions & 1 deletion core/widget/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
1 change: 0 additions & 1 deletion data/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/team/aliens/dms/android/database/meal/datasource/DatabaseMealDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package team.aliens.dms.android.database.meal.datasource

import java.time.LocalDate
import team.aliens.dms.android.core.database.entity.MealEntity
import java.time.LocalDate

abstract class DatabaseMealDataSource {
abstract suspend fun queryMeal(date: LocalDate): MealEntity
Expand Down
2 changes: 1 addition & 1 deletion .../main/java/team/aliens/dms/android/database/meal/datasource/DatabaseMealDataSourceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package team.aliens.dms.android.database.meal.datasource

import java.time.LocalDate
import team.aliens.dms.android.core.database.dao.MealDao
import team.aliens.dms.android.core.database.entity.MealEntity
import java.time.LocalDate
import javax.inject.Inject

internal class DatabaseMealDataSourceImpl @Inject constructor(
Expand Down
3 changes: 0 additions & 3 deletions feature/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand All @@ -63,7 +62,6 @@ dependencies {
implementation(project(ProjectPaths.Core.NETWORK))
implementation(project(ProjectPaths.Core.DEVICE))


implementation(project(ProjectPaths.NETWORK))
implementation(project(ProjectPaths.DATA))

Expand Down Expand Up @@ -96,7 +94,6 @@ dependencies {

implementation(libs.threetenbp)


testImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.junit)
}
1 change: 0 additions & 1 deletion network/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ android {
kotlinOptions {
jvmTarget = Versions.java.toString()
}

}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion shared/date/src/test/java/team/aliens/dms/android/shared/date/junit/DateUtilsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package team.aliens.dms.android.shared.date.junit

import org.junit.Test
import java.time.LocalDate
import team.aliens.dms.android.shared.date.util.now
import team.aliens.dms.android.shared.date.util.today
import java.time.LocalDate

class DateUtilsTest {

Expand Down
6 changes: 3 additions & 3 deletions shared/date/src/test/java/team/aliens/dms/android/shared/date/junit/ExtensionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ package team.aliens.dms.android.shared.date.junit

import org.junit.Before
import org.junit.Test
import java.time.LocalDate
import java.time.LocalDateTime
import java.time.ZoneOffset
import team.aliens.dms.android.shared.date.toDate
import team.aliens.dms.android.shared.date.toEpochMilli
import team.aliens.dms.android.shared.date.toLocalDate
import team.aliens.dms.android.shared.date.toLocalDateTime
import java.time.LocalDate
import java.time.LocalDateTime
import java.time.ZoneOffset
import java.util.Date

class ExtensionsTest {
Expand Down
Loading