🔀 :: (#946) 새벽 자습 알림 토픽 누락 해결

[ashxom]

개요

DAYBREAK_STUDY_APPLICATION 토픽 누락으로 인한 알림 조회 오류를 해결합니다.

작업사항

추가 로 할 말

Summary by CodeRabbit

• New Features
  • Added support for a new notification topic, enabling notifications for the Daybreak Study Application feature.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03bd6285-4cce-4db5-bd20-8d4c512ef7b6

📥 Commits

Reviewing files that changed from the base of the PR and between 37b2026 and 4aa9c62.

📒 Files selected for processing (1)

• data/src/main/kotlin/team/aliens/dms/android/data/notification/model/NotificationTopic.kt

---

📝 Walkthrough

Walkthrough

A new enum constant DAYBREAK_STUDY_APPLICATION is added to the NotificationTopic enum in the data layer, extending the set of available notification topics. The existing conversion logic that maps NotificationTopic.Subscription to BatchUpdateNotificationTopicRequest.NotificationTopicRequest via topic.name is unchanged.

Changes

Notification Topic Extension

Layer / File(s)	Summary
Add DAYBREAK_STUDY_APPLICATION enum constant data/src/main/kotlin/team/aliens/dms/android/data/notification/model/NotificationTopic.kt	Appends DAYBREAK_STUDY_APPLICATION to the NotificationTopic enum after OUTING; no changes to conversion logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A new topic hops into the enum today,
DAYBREAK_STUDY_APPLICATION is here to stay!
One constant added, neat and trim,
The topic list no longer dim.
Hop along, notifications — find your way! 🌅

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title is partially related to the main change but contains non-English text and emojis that obscure clarity for international developers.	Consider using a clear English title such as 'Add DAYBREAK_STUDY_APPLICATION notification topic' for better clarity and team accessibility.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bug/946-새벽-자습-알림-토픽-누락

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}