🔀 :: (#948) 새벽 자습 신청 화면 UI 불일치 수정

[ashxom]

개요

새벽 자습 신청 화면에서 디자인 시안과 실제 구현 UI가 다르게 표시되는 걸 해결했습니다.

작업사항

추가 로 할 말

Summary by CodeRabbit

• Bug Fixes

  • Teacher filtering now uses case-insensitive search matching for improved discoverability
  • Text highlighting in search results updated to match case-insensitively

• Style

  • Improved application card text display with better truncation and ellipsis handling
  • Refined teacher dropdown styling with enhanced visual appearance, spacing, and theme consistency

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2311b4bc-30cd-4e4e-8c33-bd206dc8b782

📥 Commits

Reviewing files that changed from the base of the PR and between ecfbe5d and 643da48.

📒 Files selected for processing (2)

• core/design-system/src/main/java/team/aliens/dms/android/core/designsystem/card/DmsApplicationCard.kt
• feature/src/main/kotlin/team/aliens/dms/android/feature/latestudy/ui/LateStudyScreen.kt

---

📝 Walkthrough

Walkthrough

The PR makes two UI adjustments: DmsApplicationCard gains single-line ellipsis truncation and a labelM typography switch for the chip label, while LateStudyScreen refactors the teacher dropdown to use theme-driven styling variables, case-insensitive teacher filtering and keyword highlighting, an iconColor parameter on TeacherDropdownItem, and updated container shadow/layout values.

Changes

DmsApplicationCard chip label

Layer / File(s)	Summary
AppliedTitleText truncation and typography core/design-system/.../card/DmsApplicationCard.kt	Adds TextOverflow import, removes unused labelB import, switches chip label to labelM typography, and adds maxLines = 1 with TextOverflow.Ellipsis truncation.

LateStudyScreen teacher dropdown refactor

Layer / File(s)	Summary
Case-insensitive teacher filtering and highlight matching feature/.../latestudy/ui/LateStudyScreen.kt	Changes filteredTeachers to use contains(..., ignoreCase = true) and rewrites highlightText to locate keyword matches with indexOf(..., ignoreCase = true).
TeacherDropdown theming variables and container styling feature/.../latestudy/ui/LateStudyScreen.kt	Introduces shape, highlightColor, iconColor, and shadowColor from DmsTheme; updates dropdown container to use shadow(...), semi-transparent background, adjusted vertical offset and max height; adds iconColor parameter to TeacherDropdownItem for the leading search icon tint.
Minor formatting cleanups feature/.../latestudy/ui/LateStudyScreen.kt	Reformats DateSelectSection when-branch assignments, removes trailing comma in resultStore.setResult(...), and reformats the "유형" label padding modifier—no logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• uson1004

Poem

🐇 A chip label now trims with grace,
No overflow cluttering its tiny space.
The teacher search ignores the case—
Uppercase, lowercase, all embrace!
With shadows styled and icons tinted right,
The dropdown glows with theme-driven light. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references issue #948 and describes fixing UI inconsistencies in the early morning self-study application screen, which directly aligns with the main changes across both modified files (design system card updates and LateStudyScreen UI refinements).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bug/948-새벽-자습-신청-화면-ui-불일치-수정

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}