Skip to content

feat: add (isNull, checkDomain) util function#21

Merged
klmhyeonwoo merged 2 commits into
mainfrom
feature/util-workspace
Aug 30, 2025
Merged

feat: add (isNull, checkDomain) util function#21
klmhyeonwoo merged 2 commits into
mainfrom
feature/util-workspace

Conversation

@klmhyeonwoo
Copy link
Copy Markdown
Member

@klmhyeonwoo klmhyeonwoo commented Aug 29, 2025

closes: #16
closes: #14

Copilot AI review requested due to automatic review settings August 29, 2025 10:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new isNull utility function that provides a type guard for checking if a value is strictly null. The implementation includes comprehensive test coverage and documentation updates.

  • Implements a type-safe null checking utility with TypeScript type guard
  • Adds comprehensive test cases covering various falsy values
  • Updates package exports and documentation with usage examples

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
package/commonUtil/isNull/index.ts Core implementation of the isNull type guard function
package/commonUtil/isNull/index.test.ts Test suite covering null and non-null value scenarios
package/commonUtil/index.ts Exports the new isNull function from the package
README.md Updates documentation with usage examples and API reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@klmhyeonwoo
Copy link
Copy Markdown
Member Author

klmhyeonwoo commented Aug 29, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.15% 83 / 176
🔵 Statements 47.15% 83 / 176
🔵 Functions 59.09% 13 / 22
🔵 Branches 81.13% 43 / 53
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
package/commonUtil/index.ts 0% 0% 0% 0% 1-2
package/commonUtil/isNull/index.ts 100% 100% 100% 100%
package/validationUtil/index.ts 0% 0% 0% 0% 1-3
package/validationUtil/checkDomain/index.ts 100% 100% 100% 100%
Generated in workflow #31 for commit c7098dc by the Vitest Coverage Report Action

@klmhyeonwoo klmhyeonwoo changed the title feat: add isNull util function (#16) feat: add (isNull, checkDomain) util function Aug 29, 2025
@klmhyeonwoo klmhyeonwoo requested a review from prgmr99 August 29, 2025 10:28
Copy link
Copy Markdown
Member

@prgmr99 prgmr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!!

@klmhyeonwoo klmhyeonwoo merged commit af356d7 into main Aug 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commonUtil > isNull() validationUtil > checkDomain()

3 participants