Remove calls to WebStorage JS methods, fixes #2772

[bkleinen]

Removed calls to deprecated methods. See

https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES

4.24.0 (2024-08-23)

• Deprecate WebStorage JS methods (#14276)

SeleniumHQ/selenium#14276

SeleniumHQ/selenium@fc6c070

[bkleinen]

Issue: #2772

[flugsio]

I might be wrong, but it seems that this is just deprecated to get an overview how to implement it more consistently SeleniumHQ/selenium#10397 (comment) and Motivation here SeleniumHQ/selenium#14276.

So there will probably be a replacement before removal, so I don't feel like the functionality needs to be removed here. Removing the deprecation messages is possible with

Selenium::WebDriver.logger.ignore(:logger_info, :clear_local_storage, :clear_session_storage)

This is already required in selenium projects to get rid of the logger_info message

[bkleinen]

From my understanding, Capybara already uses the replacement if the methods have been removed:
if @browser.respond_to? :session_storage
@browser.session_storage.clear
else
... call js methods directly

-> thus, I see no need to wait for the actual removement of the methods, and think they can be removed already.

[flugsio]

Oh I see, I didn't fully read the capybara implementation 🤦 ... Thanks for explaining it!

PR looks good to me 👍

[olleolleolle]

👋 I am using this branch, and it's working great. Thanks for keeping my output readable!

[wwahammy]

@bkleinen thanks for the great work here and thanks for all of the awesome work @twalpole. Is there anything the rest of us can do to help get this across the finish line?

[sethhorsley]

Are there any blockers getting this merged in?