Skip to content

Commit 30ce7d7

Browse files
author
Dheeraj Prakash
committed
fix DualLimitedController possibly not obeying reverse limit under manual move
1 parent 5aa58a2 commit 30ce7d7

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

src/main/java/org/hyperonline/hyperlib/controller/limits/DualLimitedController.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,15 @@ public boolean canMove(DoubleSupplier speed) {
3838
return this.canMove(speed.getAsDouble());
3939
}
4040

41-
// delegate methods to controller classes
42-
43-
public void move(double speed) {
41+
public void move(DoubleSupplier speed) {
4442
forwardController.move(speed);
4543
}
4644

47-
public void move(DoubleSupplier speed) {
48-
forwardController.move(speed);
45+
// delegate methods to controller classes
46+
47+
public void move(double speed) {
48+
if (speed > 0 && canMoveForward()) forwardController.move(speed);
49+
if (speed < 0 && canMoveReverse()) reverseController.move(speed);
4950
}
5051

5152
public void stop() {

0 commit comments

Comments
 (0)