Enable some useful linters, and correct a couple linting errors.

tech10 · tech10 · commit 3e97384bba61 · 2023-03-20T09:17:32.000-06:00
diff --git a/.golangci.toml b/.golangci.toml
@@ -8,14 +8,17 @@
     "asciicheck",
     "bidichk",
     "contextcheck",
+    "decorder",
     "depguard",
     "dogsled",
     "dupl",
+    "dupword",
     "errcheck",
     "errname",
     "errorlint",
     "exportloopref",
     "forcetypeassert",
+    "gocheckcompilerdirectives",
     "goconst",
     "gocyclo",
     "godot",
@@ -37,6 +40,7 @@
     "unparam",
     "unused",
     "vetshadow",
+    "wastedassign",
     "whitespace",
   ]
 
diff --git a/server/commands.go b/server/commands.go
@@ -44,8 +44,8 @@ func init() {
 				return
 			}
 		}
-		password := ""
-		locked := false
+		var password string
+		var locked bool
 		db.Channel, password, locked = getChannelParams(db.Channel)
 		if db.Channel == "" {
 			enc, encerr := Encode(Data{
diff --git a/server/file.go b/server/file.go
@@ -55,7 +55,7 @@ func fullPath(old_path string) string {
 		return cleanPath(e_path)
 	}
 	e_path = ""
-	n_path := ""
+	var n_path string
 	err = nil
 	for _, v := range strings.Split(path, PS) {
 		e_path += v + PS

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,8 @@ func init() {`
`44`	`44`	`return`
`45`	`45`	`}`
`46`	`46`	`}`
`47`		`- password := ""`
`48`		`- locked := false`
	`47`	`+ var password string`
	`48`	`+ var locked bool`
`49`	`49`	`db.Channel, password, locked = getChannelParams(db.Channel)`
`50`	`50`	`if db.Channel == "" {`
`51`	`51`	`enc, encerr := Encode(Data{`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func fullPath(old_path string) string {`
`55`	`55`	`return cleanPath(e_path)`
`56`	`56`	`}`
`57`	`57`	`e_path = ""`
`58`		`- n_path := ""`
	`58`	`+ var n_path string`
`59`	`59`	`err = nil`
`60`	`60`	`for _, v := range strings.Split(path, PS) {`
`61`	`61`	`e_path += v + PS`